Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ideas to keep developing the package #67

Open
ian-flores opened this issue Mar 6, 2019 · 10 comments
Open

Ideas to keep developing the package #67

ian-flores opened this issue Mar 6, 2019 · 10 comments
Labels
help wanted Extra attention is needed improvement New feature or request

Comments

@ian-flores
Copy link
Collaborator

ian-flores commented Mar 6, 2019

I would like to keep developing the package, here are my ideas:

  • Add a theme for people acromatopsia

    • People with monochromatic vision can see no colour at all and their world consists of different shades of grey ranging from black to white, rather like only seeing the world on an old black and white television set.
  • Try to add shapes that might distinguish between backgrounds like in old figures or the one attached?

    • image

      • It's from the data viz book suggested in DSCI 532
    • This last one would be to combine the shapes with colours themes that we have already created.

  • Verify that the package works with autoplots from time series and maps

  • Create functions that returns the palettes so that they can use them in combination with the leaflet package.

    • Format: pal() and it returns a colour palette
@ian-flores
Copy link
Collaborator Author

@sabrinatkk @hfboyce

@hfboyce
Copy link
Collaborator

hfboyce commented Mar 6, 2019

Also a grey scale palette would be useful!

@ian-flores ian-flores added improvement New feature or request help wanted Extra attention is needed labels Mar 6, 2019
@ian-flores
Copy link
Collaborator Author

Looking at the description of acromatopsia, it would fall under the grey scale palette.

Also, how about we call that one theme_acroma()?

@sabrinatkk
Copy link
Collaborator

I love this roadmap, team!

I think our priority ranking can be:

  1. Theme for people with achromatopsia. I see this as a "quicker" implementation as we already have the process for the other three. It is the most impactful/useful for people within the colourblind community.

  2. alter shapes for differentiation for all four themes.

@hfboyce @ian-flores What do you think?

@ian-flores
Copy link
Collaborator Author

I agree Sabrina. How do you want to divide the workload? I can set up the function for theme_acroma() and then send a PR and once someone else has the palette they can add to the PR as well

@hfboyce
Copy link
Collaborator

hfboyce commented Mar 7, 2019

I can make the palette!!! I already have an idea of how I would design it.

@ian-flores
Copy link
Collaborator Author

@hfboyce are we going to work on this? If so, I'll keep the issue open, if not then let's do a clean up and remove issues and PR's from the settings.

@hfboyce
Copy link
Collaborator

hfboyce commented May 24, 2020

I think we should keep it open!

@sabrinatkk
Copy link
Collaborator

sabrinatkk commented May 27, 2020 via email

@hfboyce
Copy link
Collaborator

hfboyce commented May 27, 2020

I cannot believe you are a mom now! Baby Ethaniel is so lucky! I can't even take care of myself let alone another life!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed improvement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants