Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search failure for pimâtisiwina #1198

Open
fbanados opened this issue Oct 8, 2024 · 2 comments
Open

Search failure for pimâtisiwina #1198

fbanados opened this issue Oct 8, 2024 · 2 comments

Comments

@fbanados
Copy link
Member

fbanados commented Oct 8, 2024

There's an issue with some searches like pimâtisiwina.

Currently locally detected a list index out of range error, which should be checked on.

@fbanados
Copy link
Member Author

fbanados commented Oct 8, 2024

Issue relates to preverbs. Failure currently at

id: Optional[int] = entries[0]["id"]

when tag='PV/mahti+'.

This can be solved in two ways:

  • Default to unfound result when entries[0] fails, would provide some results whenever this code fails, deploying that as a temporary fix.
  • @aarppe Main problem is that there is no entry in importjson for mahti that has inflectional_category="IPV", as expected by
    if _info["wordclass"] == "IPV":
    . Currently there are entries with IPC, IPJ, IPH, and V. Should these all be accepted instead of IPV (or just V?)

fbanados added a commit that referenced this issue Oct 8, 2024
@fbanados
Copy link
Member Author

fbanados commented Oct 9, 2024

Immediate issue has been fixed in production with the hotfix, but decision on handling Preverbs that are not an IPV remains a concern that needs to be addressed before closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant