Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content update: presentation of nêpit #1180

Open
fbanados opened this issue Jun 28, 2024 · 1 comment
Open

Content update: presentation of nêpit #1180

fbanados opened this issue Jun 28, 2024 · 1 comment
Labels
question Further information is requested review-ready

Comments

@fbanados
Copy link
Member

nêpit currently breaks the relabelling:

Screenshot 2024-06-28 at 10 53 47 AM

Also for nêpiyit:
Screenshot 2024-06-28 at 10 54 28 AM

@fbanados
Copy link
Member Author

There's two things going on:

  • For the None" The text in a Lexical Entry is Optional[str]. At serializing time, we should replace the None with a "" empty string.
  • The arrow messaging for an Initial Change is directly coded in CreeDictionary/API/search/presentation.py, following this comment. It's ok if that is the text that should be presented, but it may benefit from some heading at least, and we should discuss whether this should be placed somewhere else instead of directly encoded in python as to make the dictionary more language agnostic.

@fbanados fbanados added review-ready question Further information is requested labels Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested review-ready
Projects
None yet
Development

No branches or pull requests

1 participant