Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update English phrase FOMA FSTs #1158

Open
aarppe opened this issue Mar 21, 2023 · 5 comments
Open

Update English phrase FOMA FSTs #1158

aarppe opened this issue Mar 21, 2023 · 5 comments
Assignees
Labels
crkeng Affects itwêwina: the Plains Cree dictionary Improvement Expansion or improvement of a current functionality that does already work and meets previous specs

Comments

@aarppe
Copy link
Contributor

aarppe commented Mar 21, 2023

I've recompiled the English phrase analysis and generation FOMA FSTs, cf.

-rw-r--r--  1 arppe  staff  682821 20 Mar 18:32 src/transcriptions/transcriptor-cw-eng-noun-entry2inflected-phrase-w-flags.fomabin
-rw-r--r--  1 arppe  staff  599759 20 Mar 19:14 src/transcriptions/transcriptor-cw-eng-verb-entry2inflected-phrase-w-flags-and-templates.fomabin
-rw-r--r--  1 arppe  staff  613779 20 Mar 18:20 src/transcriptions/transcriptor-eng-phrase2crk-features.fomabin

... and am placing these in the designated subdirectory in our repo, in: ./morphodict/src/CreeDictionary/res/fst/

If pushing these to the repo won't work, these FOMA FSTs can be compiled with foma -l with the associates *.xfscript files in ./lang-crk/src/transcriptions/.

@aarppe
Copy link
Contributor Author

aarppe commented Mar 21, 2023

I also uploaded these to our subrepo intended for large FSTs: https://github.com/UAlbertaALTLab/fst-exchange

@aarppe
Copy link
Contributor Author

aarppe commented Mar 21, 2023

@nienna73 We might want to upload these, as using them should fix certain glitches in the English phrase translations with the original versions of the FOMABINs, presumably following the instructions here: https://github.com/UAlbertaALTLab/morphodict/tree/main/src/CreeDictionary/phrase_translate.

@aarppe aarppe added crkeng Affects itwêwina: the Plains Cree dictionary Improvement Expansion or improvement of a current functionality that does already work and meets previous specs labels Mar 21, 2023
@fbanados
Copy link
Member

This connects to work needed for #1166

@fbanados fbanados self-assigned this May 14, 2024
@fbanados fbanados assigned fbanados and unassigned fbanados Jun 25, 2024
@fbanados
Copy link
Member

@aarppe clarification needed: The following are the FOMA FSTs actually in use in the code (link to line where they appear:)

If there is an intention to instead run the phrase-w-flags-and-templates FSTs instead, let me know.

@aarppe
Copy link
Contributor Author

aarppe commented Jun 25, 2024

@fbanados The generator for English verb phrases used a new approach (templates), and was renamed accordingly (so the code reference should also be updated); the approaches for English noun phrase generation and general English phrase analysis didn't change, nor did the names, but there may have been modifications to the FOMABIN files. I thought I had updated and uploaded those three files, described above. Anyhow, the code mismatch might well explain why the English phrase FSTs are not fully working as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crkeng Affects itwêwina: the Plains Cree dictionary Improvement Expansion or improvement of a current functionality that does already work and meets previous specs
Projects
None yet
Development

No branches or pull requests

2 participants