Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Deprecate active_group creation #155

Open
astrochun opened this issue Jul 15, 2021 · 0 comments
Open

Enhancement: Deprecate active_group creation #155

astrochun opened this issue Jul 15, 2021 · 0 comments
Labels
enhancement New feature or request p2 Tier-2 issues that require addressing but not imminent scripts Script development

Comments

@astrochun
Copy link
Contributor

astrochun commented Jul 15, 2021

Summary

Previously we had a Grouper stem called active_group to add users manually to the active group with the user_update script. This was to handle large groups and to avoid a lot of manual adds to the active group, which should only consists of indirect membership. With ReQUIAM deployment complete for some time, this feature is really not needed as we learned recently for one user who left the university.

Objectives

This will reduce the codebase and avoid confusion when the user_update is executed on a user that is not in active status (i.e., just clean-up status)

Proposal

Simply removing the lines in question and conducting some dry run test on local dev should suffice.

Testing notes

See above.

Additional notes

For now, I do not think we should remove the --active_remove option. Namely, we should still have this supported (some changes to conditionals are needed). There are still a number of users that have direct membership. We can use this to remove those users through the Grouper API.

Implemented in: TBD

@astrochun astrochun added enhancement New feature or request scripts Script development p2 Tier-2 issues that require addressing but not imminent labels Jul 15, 2021
@astrochun astrochun added this to the v0.18.0 milestone Jul 15, 2021
@astrochun astrochun self-assigned this Jul 15, 2021
@astrochun astrochun changed the title Bug: Deprecate active_group creation Enhancement: Deprecate active_group creation Jul 15, 2021
@astrochun astrochun modified the milestones: v0.18.0, v0.19.0 Jul 21, 2021
@astrochun astrochun removed their assignment Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request p2 Tier-2 issues that require addressing but not imminent scripts Script development
Projects
None yet
Development

No branches or pull requests

1 participant