Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#33 / 초대장 보내기 받기 서버통신 구현 #69

Merged
merged 10 commits into from
Jul 19, 2023

Conversation

taeheeL
Copy link
Contributor

@taeheeL taeheeL commented Jul 19, 2023

📌 관련 이슈

📷 screenshot

default.mp4

📝 Work Desciption

  • 초대 코드 발급 받고 Intent로 넘기기
  • 초대 코드 QuickShare 로 공유 가능하게 기능 추가
  • 초대 코드 확인해 연결하기 서버통신 구현

📚 Reference 혹은 궁금한 사항들

  • 자잘자잘한 디테일 사항들 남겨주시면 QA 리스트에 업로드 하겠습니다

@taeheeL taeheeL added feat 구현 및 개선 Pull Request 🔥 풀리퀘 날림 태희 🦊 유니의 대장 담당 labels Jul 19, 2023
@taeheeL taeheeL added this to the Phase3 milestone Jul 19, 2023
@taeheeL taeheeL requested review from jinsu4755, jiyeoon00, 2zerozu and a team July 19, 2023 18:27
@taeheeL taeheeL self-assigned this Jul 19, 2023
Copy link
Contributor

@rkdmf1026 rkdmf1026 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안드의 신....

Comment on lines 8 to 9
@SerialName
("inviteCode")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 한줄로 하자

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오잉

Comment on lines 3 to +4
const val MAX_LENGTH = 10
const val INVITECODE = "inviteCode"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 내가 쓰는 const value 여기다가 빼야겠다.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헤헤 알아봐주셔서 감사합니다

lifecycleScope.launch {
enterInviteCodeViewModel.connectState.collect { responseCode ->
if (responseCode == "204") {
[email protected]("커플 연결에 성공했습니다")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extract string resource

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

어머나

onBoardingRepository.postCheckConnection(inviteCode = inviteCode.value)
}.fold({
connectState.emit(it.code().toString())
Timber.d("커플 연결 통신에 성공했습니다. code = ${it.code()}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginTop="4dp"
android:text="입력하신 코드 정보를 찾을 수 없어요"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@taeheeL taeheeL merged commit ed823b7 into develop Jul 19, 2023
1 check passed
@taeheeL taeheeL deleted the feature/#33-invite-code branch July 19, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 구현 및 개선 태희 🦊 유니의 대장 담당 Pull Request 🔥 풀리퀘 날림
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[초대 코드 공유] 코드 복사 및 상대 연결 확인 서버통신
2 participants