Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Room] Access token is sent along socket data #9

Open
TylerJDev opened this issue Jan 28, 2020 · 0 comments
Open

[Room] Access token is sent along socket data #9

TylerJDev opened this issue Jan 28, 2020 · 0 comments
Assignees
Labels
bug Something isn't working Room Issues/enhancement for the room component

Comments

@TylerJDev
Copy link
Owner

Within the file "\UsersRoomsPage\index.vue", the users access token is sent along with the data sent via the socket.

On line 64

this.socketConnect.on('user', (data) => { ... });

Data returns the following:

[
  {
    "id": "id",
    "userCount": 1,
    "access_token": "ACCESS_TOKEN",
    "devices": {
      "devices": [
        {
          "id": "id",
          "is_active": false,
          "is_private_session": false,
          "is_restricted": false,
          "name": "Device",
          "type": "Computer",
          "volume_percent": 21
        }
      ]
    }
  }
]

Alongside of the access_token, the device(s) ID is also being returned. This data should not reach the client side, only the back end for usage of validation.

@TylerJDev TylerJDev added bug Something isn't working Room Issues/enhancement for the room component labels Jan 28, 2020
@TylerJDev TylerJDev self-assigned this Jan 28, 2020
@TylerJDev TylerJDev changed the title {Room] Access token is sent along socket data [Room] Access token is sent along socket data Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Room Issues/enhancement for the room component
Projects
None yet
Development

No branches or pull requests

1 participant