Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging APIs affects the Production timer #62

Open
Skilly146 opened this issue Jan 18, 2023 · 0 comments
Open

Merging APIs affects the Production timer #62

Skilly146 opened this issue Jan 18, 2023 · 0 comments

Comments

@Skilly146
Copy link
Collaborator

Skilly146 commented Jan 18, 2023

What

When merging (doesn't affect view as far as I can tell) apis with a player the production timer becomes off from the actual time by about 10 seconds. When you merge more players the timer gets off by more time.

Why

Seems like the tick_fragment value from the merged players api is replacing the accurate one from the actual server and since there is some delay in making the api call and displaying it to the user that would explain why it is off. I assume the reason it only happens with merge is because view doesn't touch as many variables or something

How

Seems like all we have to do to fix this is have merge api stop viewing the merged players tick_fragment and only use the server provided one. While we are fixing this we might as well limit a couple other things that aren't necessary like game name, settings, etc, to avoid any future problems

Note

I made this issue on the NPA repo as well since both extensions are affected by the bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant