Application throws error if it's closed during heavy replication

[EmiM]

2022-04-21T17:26:52.033Z waggle:db Stopping OrbitDB
2022-04-21T17:26:52.090Z waggle:db Stopping IPFS
TypeError: Cannot read properties of null (reading 'length')
    at Replicator.onReplicationProgress (C:\Users\Emi\AppData\Local\Programs\quiet\resources\app.asar\node_modules\@quiet\waggle\node_modules\orbit-db-store\src\Store.js:98:25)
    at onProgressCallback (C:\Users\Emi\AppData\Local\Programs\quiet\resources\app.asar\node_modules\@quiet\waggle\node_modules\orbit-db-store\src\Replicator.js:147:14)
    at addToResults (C:\Users\Emi\AppData\Local\Programs\quiet\resources\app.asar\node_modules\@quiet\waggle\node_modules\ipfs-log\src\entry-io.js:116:17)
    at C:\Users\Emi\AppData\Local\Programs\quiet\resources\app.asar\node_modules\@quiet\waggle\node_modules\ipfs-log\src\entry-io.js:151:11
C:\Users\Emi\AppData\Local\Programs\quiet\resources\app.asar\node_modules\@quiet\waggle\lib\libp2p\connectionsManager.js:224
            throw new Error();
            ^

Error
    at process.<anonymous> (C:\Users\Emi\AppData\Local\Programs\quiet\resources\app.asar\node_modules\@quiet\waggle\lib\libp2p\connectionsManager.js:224:19)
    at process.emit (node:events:390:28)
    at processEmit [as emit] (C:\Users\Emi\AppData\Local\Programs\quiet\resources\app.asar\node_modules\@quiet\waggle\node_modules\signal-exit\index.js:197:34)
    at emit (node:internal/process/promises:136:22)
    at processPromiseRejections (node:internal/process/promises:242:25)
    at processTicksAndRejections (node:internal/process/task_queues:97:32)

[holmesworcester]

should we assume this is fixed in the latest release and QA it?

[siepra]

should we assume this is fixed in the latest release and QA it?

In the logs above we can see the problem lies in networking layer so I'm afraid the answer is no. I'll try to reproduce it and get to the bottom of the problem

[siepra]

So here are the logs from closing window. It seems like the OrbitDB has stopped but waggle still tries to accomplish queued replication tasks (which causes error on reading undefined oplog instance)

[siepra]

It's OrbitDB problem. I opened a ticket and prepared a sample repo that illustrates the issue
orbitdb-archive/orbit-db-store#121

[siepra]

Patched with version 0.28.5 (orbitdb)

[siepra]

This issue is also related as it resolves problems with performance regressions #491

[siepra]

Related PR #490