Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signifying duplicate usernames #2685

Open
jgaylor opened this issue Dec 31, 2024 · 6 comments
Open

Signifying duplicate usernames #2685

jgaylor opened this issue Dec 31, 2024 · 6 comments

Comments

@jgaylor
Copy link
Collaborator

jgaylor commented Dec 31, 2024

Update the text to reflect this change. Image

@jgaylor jgaylor added this to Quiet Dec 31, 2024
@jgaylor jgaylor converted this from a draft issue Dec 31, 2024
@jgaylor
Copy link
Collaborator Author

jgaylor commented Dec 31, 2024

@holmesworcester Before I update all the components I want to confirm this is what you had in mind: I mocked it up here:

@jgaylor jgaylor moved this from Design In Progress to Design - Awaiting Internal Feedback in Quiet Dec 31, 2024
@holmesworcester
Copy link
Contributor

"Same name" isn't clear enough, I don't think. I was wrong about updating this everywhere and thanks for checking!

I think we can keep using the "duplicate" label and use the new text when we have more space.

Image

@holmesworcester holmesworcester moved this from Design - Awaiting Internal Feedback to Design In Progress in Quiet Jan 16, 2025
@holmesworcester
Copy link
Contributor

@jgaylor can you post a link here to whatever warning we're showing the user whose name is a duplicate?

@jgaylor
Copy link
Collaborator Author

jgaylor commented Jan 16, 2025

@holmesworcester I don't think we did anything specific for when 'you' are a duplicate and you're viewing yourself—However, reviewing the designs, 'duplicate' as shown to others users would also be shown next to your own name in all the same places. Perhaps we alter the copy of the red banner if you are also included, but you'd be seeing it by your name anyway. Is that what you meant?

@holmesworcester
Copy link
Contributor

Yeah. Though in this case we would want to prompt the users (especially the new user) to change their name.

@jgaylor
Copy link
Collaborator Author

jgaylor commented Jan 16, 2025

@holmesworcester added the mockup to include a 'change username' action when it's you.

@jgaylor jgaylor moved this from Design In Progress to Design - Awaiting Internal Feedback in Quiet Jan 16, 2025
@jgaylor jgaylor moved this from Design - Awaiting Internal Feedback to Design In Progress in Quiet Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Design In Progress
Development

No branches or pull requests

2 participants