-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace username registration with a simple duplicate warning #2652
Comments
In Signal this is a warning bar across the top of the screen in any chats with duplicate names. |
We can do a warning bar in any chats idea. Just want to point out we've explored some other things:
Also, what's "Existing user registration code" mean. I'm trying to get the screens together to start working on this. |
@holmesworcester I'm trying to understand the why behind this feature, and then what users are supposed to be able to do. This will help drive the design solution. Currently, i'm just making solutions based on assumption. So, besides the maintenance burden and incompatibility rationale can you provide more information on this ticket...
|
Anyway, latest is here, for easy reference later: https://www.figma.com/design/CkkTkVhpCh2lPpF1mRd1vF/Username-(changing%2C-displaying%2C-duplicates)?node-id=2828-24755&t=BC07iebO4ivkPK0l-4 |
I think the above questions are covered by the design. In larger open communities having a "report" button would be good, but we're targeting smaller high-trust communities first, so I think just messaging admins about it is fine, and admins will see the warning too. One note on this is that we do not want a situation where someone can send a message as a duplicate name, in a DM say, without being registered, since this would hide the impersonation warning from everyone accept the targeted user. Messages from users that aren't in the sigchain should be ignored. |
Remaining todos:
On giving non-admins an action they can take: Both users who saw this asked "so what would i do here?" and it felt a bit weird that there wasn't an action. Ideally they would do something that helped resolve the problem. One idea would be to notify an admin. Another desirable thing would be for this to happen automatically. That is, admins would all get notifications for all new users and username updates, and these could be silenced depending on their settings, but duplicate usernames would always show a notification to all admins. This would require the "suppress silent notifications" permission from Apple. (This isn't design related but I'm noting it here for further work on this issue.) |
@holmesworcester The latest is here Signifying duplicate usernames Going through your bullets:
|
@holmesworcester I was finalizing this and had a couple of questions for you. Take a look at this when you get a chance. Outstanding questions:
Moving this to internal review status. |
|
Responded to questions about how to display name changes. There's a question here when we develop this feature and for user feedback about how long name changes should be visible for and whether it's desirable that they eventually get deleted from our history. I can ask people about this. |
Cleaned up stuff on Change / register usernames based on your feedback. Will look into displaying "Duplicate!" in other lists and on profiles. |
@holmesworcester for item one; I completed a first audit and identified other areas where "Duplicate!" might also need to be displayed. We previously decided to hide all other 'flair' when a user is a duplicate. I've left some of that 'flair' on the actual profile, since there's more space there, but we could choose to remove it if you think we should for symmetry. Let me know what you think. |
All of this looks good to me. Left a couple minor comments. |
Addressed your comments. Feel free to move this to backlog if you're happy with it. |
@holmesworcester You left Figma comments, I responded to them here. |
Two user-reported issues I'm still not sure what to do with:
Maybe we could add an admin action: "Suspend all" to easily suspend all duplicate accounts. Perhaps "suspend" should be the action on all of these accounts, too. |
WIth duplicates, one of them will always be the person that's legit/original/intended/verified (not sure the right word), and the other(s) might be imposter, or accidental. I was thinking when faced with duplicates you'd want to somehow warn the imposter/unverified person, but not the correct one. So "Suspend all" seems like it could be too aggressive or wrong. Couple of thoughts:
I'm still trying to understand how we end up with duplicates though. Is that because of delays between syncing or something else? |
|
Username registration has been a maintenance burden and it will not be compatible with our LFA-based, multi-admin, mutli-device plan.
Signal now warns users about duplicate usernames. This is a simple solution that will work well for us too. Let's do it, and remove existing user registration code.
We can still attempt to stop users from registering duplicate usernames and prompt them to change their names.
The text was updated successfully, but these errors were encountered: