Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Try/Tempest
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: fa35c3f10e4a38e2f065b862a746cf07e1b5b99f
Choose a base ref
...
head repository: Try/Tempest
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0cf71374a68119b87b42c5d379601ea62039c2b7
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Oct 5, 2024

  1. CI: macos sonoma (#70)

    * CI
    
    * CI
    
    * CI
    
    * CI
    
    * CI: disallow "Apple Paravirtual device"
    
    * CI
    
    * remove debug stuff
    Try authored Oct 5, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    0cf7137 View commit details
Showing with 7 additions and 1 deletion.
  1. +4 −1 Engine/CMakeLists.txt
  2. +3 −0 Engine/gapi/metal/mtdevice.mm
5 changes: 4 additions & 1 deletion Engine/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -117,7 +117,10 @@ if(TEMPEST_BUILD_AUDIO)
target_compile_options(OpenAL PRIVATE -Wno-nullability-completeness)
endif()
if(NOT MSVC)
target_compile_options(OpenAL PRIVATE -Wno-attributes -Wno-conversion -Wno-switch -Wno-stringop-overflow -Wno-unused-but-set-variable)
target_compile_options(OpenAL PRIVATE -Wno-attributes -Wno-conversion -Wno-switch -Wno-unused-but-set-variable)
endif()
if(NOT MSVC AND NOT APPLE)
target_compile_options(OpenAL PRIVATE -Wno-stringop-overflow)
endif()
endif()

3 changes: 3 additions & 0 deletions Engine/gapi/metal/mtdevice.mm
Original file line number Diff line number Diff line change
@@ -40,6 +40,9 @@
if(impl.get()==nullptr)
throw std::system_error(Tempest::GraphicsErrc::NoDevice);

if(std::strcmp(impl->name()->utf8String(), "Apple Paravirtual device")==0)
throw std::system_error(Tempest::GraphicsErrc::NoDevice, "Apple Paravirtual device is not supported");

queue = NsPtr<MTL::CommandQueue>(impl->newCommandQueue());
if(queue.get()==nullptr)
throw std::system_error(Tempest::GraphicsErrc::NoDevice);