Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's really dark outside with certain graphics mods #584

Open
hwnde opened this issue Feb 24, 2024 · 5 comments
Open

It's really dark outside with certain graphics mods #584

hwnde opened this issue Feb 24, 2024 · 5 comments
Assignees

Comments

@hwnde
Copy link
Contributor

hwnde commented Feb 24, 2024

I decided to install some texture/model mods and see how OpenGothic handles them. The mods seem to work correctly but with one major problem: it's really dark outside.

Here are the mods I tried:
Gothic II TextureMix by ARTstuff - https://www.nexusmods.com/gothic2/mods/15
Screenshot 2024-02-23 200614

Gothic II Graphics Overhaul https://www.nexusmods.com/gothic2/mods/4
Screenshot 2024-02-23 201027

Riisis Texture Mix https://www.nexusmods.com/gothic2/mods/3
Screenshot 2024-02-23 202515

@Try
Copy link
Owner

Try commented Feb 24, 2024

Reproduced with "Gothic II TextureMix by ARTstuff"
Seem to be a general problem with exposure calculation - working on it

@Try Try self-assigned this Feb 24, 2024
Try added a commit that referenced this issue Feb 27, 2024
@Try
Copy link
Owner

Try commented Feb 27, 2024

With new exposure calculation:
изображение

@hwnde
Copy link
Contributor Author

hwnde commented Feb 28, 2024

Much better!
Screenshot 2024-02-27 180055

I would argue that it should be a bit brighter still given that it's midday and the sun is not obstructed by anything but I'm okay if that's a stylistic choice.
I did notice another issue though: looks like the knight armor mesh is broken (see the screenshot)

@Try
Copy link
Owner

Try commented Feb 28, 2024

I would argue that it should be a bit brighter still given that it's midday and the sun is not obstructed by anything but I'm okay if that's a stylistic choice.

At this point I'm struggling to formalize how lighting should work and exposure is only a tip on iceberg. And the rest is #510 - would need to figure lighting and then come back to exposure.

@Try
Copy link
Owner

Try commented Feb 29, 2024

Some progress (as part of GI work):
изображение

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants