Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🦊🐺🐭 Add connectors #754

Closed
wants to merge 106 commits into from
Closed

🦊🐺🐭 Add connectors #754

wants to merge 106 commits into from

Conversation

dmaretskyi
Copy link
Contributor

@dmaretskyi dmaretskyi commented May 11, 2022 •
edited by yivlad

closes #788
closes #520
closes #419
closes #282

TODO

  • Portis connector
  • Coinbase connector
  • MetaMask connector in config by default - backwards compat.
    • By default - all connectors that do not need any user config parameters
  • When MetaMask changes network, the UI should update sooner
  • eip1193 - not working yet. Is it the same issue as above?
  • Accept readOnlyURLs in connectors for read-only connectors (ApiNode)
  • Use Event from dxos onUpdate
  • Check if useConnectorNetwork is needed
  • Reimplement pollingInterval logic
  • Consider deleting connectEagerly
  • Watch the bundle size - set the wallet packages as (optional) peer deps?

@changeset-bot
Copy link

changeset-bot bot commented May 11, 2022 •
edited

⚠️ No Changeset found

Latest commit: 1c2582b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

dmaretskyi
dmaretskyi commented May 11, 2022
View reviewed changes
packages/core/src/providers/network/connector/connectorController.ts
@@ -0,0 +1,32 @@
import { Connector } from "./connector";

export class ConnectorController {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should handle the lifecycle of the connector including chainID, accounts, block number etc.

Should have safeguards to protect from bugs in the connector implementation

@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2022 •
edited

🚀 Deployed on https://6303add666a5b926e981bf17--usedapp-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request May 11, 2022 10:22 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2022 •
edited

🚀 Deployed on https://6303ade4abac2f27819c5bee--usedapp-example.netlify.app

@github-actions github-actions bot temporarily deployed to pull request May 11, 2022 10:22 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2022 •
edited

🚀 Deployed on https://6303adec78c47a2cb9c238a3--usedapp-website.netlify.app

@github-actions github-actions bot temporarily deployed to pull request May 11, 2022 10:22 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 29, 2022 12:46 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 29, 2022 12:46 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 29, 2022 12:46 Inactive
@mj426382 mj426382 changed the title Add connectors 🦊🐺🐭 Add connectors Jun 30, 2022
@github-actions github-actions bot temporarily deployed to pull request June 30, 2022 13:05 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 18, 2022 13:25 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 18, 2022 13:25 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 18, 2022 13:25 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 18, 2022 15:20 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 18, 2022 15:20 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 18, 2022 15:21 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 19, 2022 13:22 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 19, 2022 13:22 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 19, 2022 13:22 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 22, 2022 15:14 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 22, 2022 15:15 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 22, 2022 15:15 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 22, 2022 16:04 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 22, 2022 16:04 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 22, 2022 16:04 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 22, 2022 16:25 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 22, 2022 16:25 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 22, 2022 16:25 Inactive
@yivlad yivlad closed this Sep 8, 2022
@yivlad yivlad deleted the dmaretskyi/connectors branch July 28, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rzadp rzadp rzadp left review comments

@mj426382 mj426382 mj426382 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@dmaretskyi @rzadp @mj426382 @yivlad