Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example listener in core #3501

Open
tjayrush opened this issue Feb 10, 2024 · 2 comments
Open

Add an example listener in core #3501

tjayrush opened this issue Feb 10, 2024 · 2 comments

Comments

@tjayrush
Copy link
Member

tjayrush commented Feb 10, 2024

Instead of having the listener in a different repo, it should be in the scraper.

In this way, we could easily just add a --notify option which would kick off a Go Routine that would listen.

Running the scraper is hard enough. It shouldn't be made harder.

No. It should not be in a docker file (although, I'm open to discussion, I suppose.) I don;t mind that hte scraper is in a docker, but havign separet dokcers for scraper and listener is suboptimal.

@tjayrush tjayrush changed the title The listener for the Notify function should be a command line for scrape Add an example listener in core Feb 12, 2024
@tjayrush
Copy link
Member Author

tjayrush commented Feb 12, 2024

Having Notify inside of core is great, but it requires a listener. Currently, our only example of a listener sends its results to AWS. Because we do not want to bring this code into core, but we do want to show people how they can "wire up" a listener, we could add an example listener that does nothing but fmt.Println (sort of like --file but with options for --file including stdout or stderr.

We can do this by abstracting out the ./queue/insert code into something that can be used as an example.

@dszlachta Your thoughts?

@tjayrush tjayrush reopened this Feb 12, 2024
@tjayrush
Copy link
Member Author

tjayrush commented Jun 2, 2024

@dszlachta How hard would it be to make an example of a listener that simply dumped the sent messages to the screen? I think it would be very easy...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant