Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving between pages before API call has finished may cause memory leaks #185

Open
johngribbin opened this issue Dec 11, 2019 · 1 comment
Open

Moving between pages before API call has finished may cause memory leaks #185

johngribbin opened this issue Dec 11, 2019 · 1 comment
Labels
bug Something isn't working
Projects
TruSat

Comments

@johngribbin
Copy link
Collaborator

See error in console when you navigate away from the "catalog" view before the data is returned from the API:

Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in a useEffect cleanup function.
    in CatalogTable (at Catalog.js:46)
    in div (at Catalog.js:17)
    in Catalog (created by Context.Consumer)
    in withRouter(Catalog) (created by Context.Consumer)
@johngribbin johngribbin added the bug Something isn't working label Dec 11, 2019
@johngribbin johngribbin changed the title Moving between pages before API call may cause memory leaks Moving between pages before API call has finished may cause memory leaks Dec 11, 2019
@mainnebula mainnebula added this to To do in TruSat Mar 2, 2020
@johngribbin
Copy link
Collaborator Author

See discussion on the issue here - facebook/react#15006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
TruSat
  
To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johngribbin