Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing in raw ssh key #7

Open
nimajalali opened this issue Oct 18, 2017 · 2 comments
Open

Support passing in raw ssh key #7

nimajalali opened this issue Oct 18, 2017 · 2 comments

Comments

@nimajalali
Copy link
Contributor

I'm attempting to use the Triton driver with Rancher.

Rancher runs the docker-machine command on the server side, this requires uploading the Triton ssh key to the server before hand and referencing the key path in the Rancher UI.

I'm looking to add support for passing in the raw ssh key so adding a machine can happen all within the Rancher UI.

Before I started the changes I wanted to get opinions on the approach.

We could create a new flag, --triton-key-material
or
We could overload the current flag --triton-key-path

By overload I mean we could try to interpret the triton-key-path as a file path first, if that fails we could assume the contents is a raw ssh key.

Thoughts?

@nimajalali
Copy link
Contributor Author

So I've been looking into this more and realized that the Docker Machine Driver Interface requires the following function GetSSHKeyPath() string

This means the SSH key will have to be on disk. I thought about writing a temp file with the key data but once the machine is created docker machine expects the key to persist.

An alternative approach could be to separate the key used to authenticate with the Triton Cloud API and the key used to ssh into the docker host. Then we could allow an option to generate a key for the new host or use one on disk.

@fayazg Let's discuss offline...

@jwreagor
Copy link
Contributor

jwreagor commented Nov 3, 2017

You may want to revisit this once #6 (PR #10) is merged as things have changed. Not sure if better, worse, or the same but worth a look none the less.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants