Optimize HotfixSettings for 25% perf gain when ParseAllHotfixes is disabled and no HotfixElement is enabled

Author: Shauren

WowPacketParser/Hotfix/HotfixConfiguration.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Collections.Generic;
 using System.Configuration;
 using WowPacketParser.Enums;
 using WowPacketParser.Misc;
@@ -10,33 +11,33 @@ public class HotfixSettings
         public static HotfixSettings Instance { get; } = new HotfixSettings();
 
         private HotfixSection Section => (HotfixSection)ConfigurationManager.GetSection("Hotfix");
-        private HotfixElementCollection Hashes => Section.FileHashes;
+        private IReadOnlySet<string> _hashes;
+
+        public void LoadHashes()
+        {
+            var enabledTables = new HashSet<string>();
+
+            foreach (HotfixElement sectionFileHash in Section.FileHashes)
+                if (sectionFileHash.Enabled)
+                    enabledTables.Add(sectionFileHash.FileHash);
+
+            _hashes = enabledTables;
+        }
 
         public bool ShouldLog(DB2Hash fileHash)
         {
-            for (var i = 0; i < Hashes.Count; ++i)
-            {
-                if (Settings.ParseAllHotfixes == true)
-                    return true;
-
-                var currentElement = Hashes[i];
-                if (currentElement.FileHash == fileHash.ToString())
-                    return currentElement.Enabled;
-            }
-            return false;
+            if (Settings.ParseAllHotfixes)
+                return true;
+
+            return _hashes.Contains(fileHash.ToString());
         }
 
         public bool ShouldLog()
         {
-            for (var i = 0; i < Hashes.Count; ++i)
-            {
-                if (Settings.ParseAllHotfixes == true)
-                    return true;
-
-                if (Hashes[i].Enabled)
-                    return true;
-            }
-            return false;
+            if (Settings.ParseAllHotfixes)
+                return true;
+
+            return _hashes.Count > 0;
         }
     }
 

WowPacketParser/Program.cs

@@ -7,6 +7,7 @@
 using System.Reflection;
 using System.Runtime.InteropServices;
 using System.Threading;
+using WowPacketParser.Hotfix;
 using WowPacketParser.Loading;
 using WowPacketParser.Misc;
 using WowPacketParser.Parsing.Parsers;
@@ -79,6 +80,8 @@ private static void Main(string[] args)
 
             SQLConnector.ReadDB();
 
+            HotfixSettings.Instance.LoadHashes();
+
             List<Packets> parserPacketsList = new();
 
             var processStartTime = DateTime.Now;