Skip to content
This repository has been archived by the owner on Apr 18, 2019. It is now read-only.

Weird way to use the provider in pyz_binary #56

Open
nicolov opened this issue Jan 19, 2019 · 1 comment
Open

Weird way to use the provider in pyz_binary #56

nicolov opened this issue Jan 19, 2019 · 1 comment

Comments

@nicolov
Copy link

nicolov commented Jan 19, 2019

Thanks a lot for the code, it's really useful!

I've noticed that pyz_binary uses the provider in a weird way. Usually, these leaf nodes just consume the transitive info, and can do:

for dep in ctx.attr.deps:
    for mapping in dep[PyZProvider].transitive_mappings:
        links[....

This is an updated reference for the canonical way to set this up.

@evanj
Copy link

evanj commented Jan 30, 2019

Thanks for the note. I ... do not recall why exactly I did it this way.

We've decided to not use Bazel, so this is basically unmaintained. I am unfortunately not going to have the time to figure out why it was done like this and try to fix it. Sorry.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants