Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite this library with callbacks #2

Open
Trigary opened this issue Jan 5, 2020 · 0 comments
Open

Rewrite this library with callbacks #2

Trigary opened this issue Jan 5, 2020 · 0 comments

Comments

@Trigary
Copy link
Owner

Trigary commented Jan 5, 2020

This way we can keep the autoActivate, etc options in the AdvancementFactory and still have the ability to change anything we want.

The library could also use some other changes, eg. less boilerplate for all the stuff in the Advancement constructor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Trigary