Merge pull request #316 from Trendyol/credentials-error

fix: app crash

Author: armagandalkiran

gurubu-backend/utils/groomings.js

@@ -112,7 +112,6 @@ const generateNewRoom = (nickName, groomingType) => {
   const { credentials, ...userWithoutCredentials } = user;
 
   groomings[roomID] = {
-    totalParticipants: 1,
     mode: groomingType,
     participants: { [user.userID]: userWithoutCredentials },
     metrics: groomingMode[groomingType],
@@ -149,11 +148,6 @@ const handleJoinRoom = (nickName, roomID, isAdmin) => {
     user.isAdmin = isAdmin
   }
 
-  groomings[roomID] = {
-    ...groomings[roomID],
-    totalParticipants: Object.keys(groomings[roomID].participants).length + 1,
-  };
-
   const { credentials, ...userWithoutCredentials } = user;
 
   if(!groomings[roomID]){
@@ -200,7 +194,6 @@ const removeUserFromOngoingGrooming = (roomID, userID) => {
   }
 
   delete groomings[roomID].participants[userID];
-  groomings[roomID].totalParticipants = groomings[roomID].totalParticipants - 1;
 };
 
 const updateParticipantsVote = (data, credentials, roomID, socket) => {

gurubu-client/src/app/components/room/grooming-board/grooming-board-logs.tsx

@@ -26,7 +26,7 @@ const GroomingBoardLogs = ({ roomId }: Props) => {
         <>
           <ul className="grooming-board__metrics">
             <div className="grooming-board__participants-text">
-              <span>Participants ({groomingInfo.totalParticipants || "0"})</span>
+              <span>Participants ({Object.keys(groomingInfo?.participants || {}).length || "0"})</span>
             </div>
             {groomingInfo.metrics?.map((metric) => (
               <li

gurubu-client/src/app/shared/interfaces.ts

@@ -35,7 +35,6 @@ export interface MetricAverages {
 }
 
 export interface GroomingInfo {
-  totalParticipants: number;
   mode: string;
   participants: Participants;
   metrics: Metric[];