Skip to content

[Test Coverage] Fix SVD interpreter compatibility test fixtures #1327

@jlarson4

Description

@jlarson4

Summary

Two SVD interpreter compatibility tests skip themselves at runtime due to fixture-config issues, not feature gaps.

Affected tests

  • tests/unit/model_bridge/compatibility/test_svd_interpreter.py:78: test_svd_interpreter_returns_different_answers_for_different_layers Skips with "Model only has one layer" (and yet the assertion is "different layers should differ")
  • tests/unit/model_bridge/compatibility/test_svd_interpreter.py:113: test_svd_interpreter_returns_different_answers_for_different_models Skips with "Same model used for both fixtures" (and yet the assertion is "different models should differ")

Acceptance criteria

  • Both tests use fixtures that actually meet their preconditions (multi-layer model; two distinct models).
  • Inline pytest.skip(...) is removed in both tests.
  • Both tests assert the intended behavior.

Where to start

  • Inspect the model / second_model fixtures (file-scoped or conftest.py), they're probably loading the same tiny model twice.
  • Pick a tiny multi-layer model (e.g., attn-only-2l, solu-2l) for the multi-layer test and two distinct tiny models (e.g., solu-1l, attn-only-1l) for the cross-model test.

Metadata

Metadata

Labels

TransformerBridgeBug specific to the new TransformerBridge systemcomplexity-simpleSimple issues, which may be good for beginnersgood first issueGood for newcomerslow-priorityMaintainers are not prioritising this work currently.

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions