Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

charts not visible ... #113

Open
intruder09 opened this issue Nov 1, 2019 · 7 comments
Open

charts not visible ... #113

intruder09 opened this issue Nov 1, 2019 · 7 comments

Comments

@intruder09
Copy link

I have been using this library since almost for 8-9 months ..... and today all os sudden . charts disappeared and doesn't show any error, can you let us know if there is anything new has come up.
@Yonatanos
Copy link

Yonatanos commented Nov 3, 2019 •
edited
Loading

Hi finpeg123,
I'm sharing the same problem.
The cause is that the library uses external scripts, which were updated on 31-10-2019.
Hope it will be fixed soon.

The external scripts are being used on index.js and on react-native-highchart.js:

<head> <script src="https://code.jquery.com/jquery-2.1.4.min.js"></script> ${this.props.stock ? '<script src="https://code.highcharts.com/stock/highstock.js"></script>' : '<script src="https://code.highcharts.com/highcharts.js"></script>'} ${this.props.more ? '<script src="https://code.highcharts.com/highcharts-more.js"></script>' : ''} ${this.props.guage ? '<script src="https://code.highcharts.com/modules/solid-gauge.js"></script>' : ''} <script src="https://code.highcharts.com/modules/exporting.js"></script> <script>

@jackcb123
Copy link

Hi, I have the same issue :/ all graphs in my app just went blank on 31-10-2019 as you said @Yonatanos

Does anyone know if this is a known issue by the developers of those scripts? Is it affecting other highcharts wrappers or just this one? If not, any ideas on who we can contact or are we just supposed to wait...?

@tackanoway35
Copy link

tackanoway35 commented Nov 4, 2019 •
edited
Loading

I fixed it by adding version for all external script js
Exp: https://code.highcharts.com/7.2.0/modules/exporting.js

@intruder09
Copy link
Author

can you please just paste the code

@intruder09
Copy link
Author

@tackanoway35 thanks man
just need to edit src of js in change react-native-highcharts.js

<script src="https://code.jquery.com/jquery-2.1.4.min.js"></script> 
                    ${this.props.stock ? '<script src="https://code.highcharts.com/stock/7.2.0/highstock.js"></script>'
                                  : '<script src="https://code.highcharts.com/7.2.0/highcharts.js"></script>'}
                    ${this.props.more ? '<script src="https://code.highcharts.com/7.2.0/highcharts-more.js"></script>'
                                  : ''}
                    ${this.props.guage ? '<script src=""https://code.highcharts.com/7.2.0/modules/solid-gauge.js"></script>'
                                  : ''}
                    <script src="https://code.highcharts.com/7.2.0/modules/exporting.js"></script>
                    <script>

@jigs611989
Copy link

jigs611989 commented Nov 4, 2019 •
edited
Loading

Hi Guys, I did face the same issue, In my case I didn't pass Options in props so its creating issue, it wasn't creating issue earlier.
Just pass options as props like below for quick fix.
<ChartView style={{ flex: 1, height: 250 }} config={graphConfigData} javaScriptEnabled domStorageEnabled originWhitelist={['']} options='' />

I have crated Pull Requested by fixing null/undefined option props.

https://github.com/TradingPal/react-native-highcharts/pull/114/files

@njt1982
Copy link

njt1982 commented Nov 11, 2019

@jigs611989 this solved a mysterious disappearing chart for our React Native on ios app too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@njt1982 @jigs611989 @tackanoway35 @Yonatanos @jackcb123 @intruder09