Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doesn't work with rollup #65

Open
pjebs opened this issue Apr 16, 2020 · 4 comments
Open

doesn't work with rollup #65

pjebs opened this issue Apr 16, 2020 · 4 comments

Comments

@pjebs
Copy link

pjebs commented Apr 16, 2020

I'm trying to use this with rollup (bundler) and electron.

It doesn't seem to work: See #29 (comment)
@pjebs
Copy link
Author

pjebs commented Apr 16, 2020

The error can be seen in my comment above.

@tomsseisums
Copy link

It's not rollup only, everything that will bundle into a single file will cause this problem.

@tomsseisums
Copy link

I temporarily fixed this for serialport by marking the serialport as external in webpack so that it's loaded from node_modules.

@pjebs
Copy link
Author

pjebs commented Jun 2, 2020

I did something similar but it does mean I need to distribute the node_modules directory with my electron application.

@blimmer blimmer mentioned this issue Dec 15, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomsseisums @pjebs