From ae66fe7f55f6466a5ce4b0db559e1308d99b077b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Antonio=20Serrano=20Mu=C3=B1oz?= Date: Sat, 3 Aug 2024 18:28:59 -0400 Subject: [PATCH] Close the environment in the base class and add render return annotation --- skrl/envs/wrappers/torch/base.py | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/skrl/envs/wrappers/torch/base.py b/skrl/envs/wrappers/torch/base.py index 153da0a3..4ce2bb90 100644 --- a/skrl/envs/wrappers/torch/base.py +++ b/skrl/envs/wrappers/torch/base.py @@ -64,15 +64,18 @@ def step(self, actions: torch.Tensor) -> Tuple[torch.Tensor, torch.Tensor, torch """ raise NotImplementedError - def render(self, *args, **kwargs) -> None: + def render(self, *args, **kwargs) -> Any: """Render the environment + + :return: Any value from the wrapped environment + :rtype: any """ - pass + return None def close(self) -> None: """Close the environment """ - pass + self._env.close() @property def num_envs(self) -> int: @@ -168,15 +171,18 @@ def step(self, actions: Mapping[str, torch.Tensor]) -> \ """ raise NotImplementedError - def render(self, *args, **kwargs) -> None: + def render(self, *args, **kwargs) -> Any: """Render the environment + + :return: Any value from the wrapped environment + :rtype: any """ - pass + return None def close(self) -> None: """Close the environment """ - pass + self._env.close() @property def num_envs(self) -> int: