Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support v5.8.0 #1

Open
craftzdog opened this issue Mar 8, 2024 · 11 comments
Open

Support v5.8.0 #1

craftzdog opened this issue Mar 8, 2024 · 11 comments

Comments

@craftzdog
Copy link

Hi TaylanTatli!

I just released v5.8.0-beta.1, which comes with a bunch of UI improvements:

https://forum.inkdrop.app/t/inkdrop-desktop-v5-8-0-beta-1/4473

It has some accessibility improvements, which require custom themes to update.
The release notes mention how to update your theme.
Could you check it out?

Thanks for creating a great theme!

@TaylanTatli
Copy link
Collaborator

Sure. Thanks for your hard works. @TolgaTatli can you help me for this?

@TolgaTatli
Copy link
Owner

Sure. Thanks for your hard works. @TolgaTatli can you help me for this?

Absolutely. I can help you to update your theme.

@TaylanTatli
Copy link
Collaborator

@craftzdog I can't publish the new version because it asks for API Token, but there is no such thing on my inkdrop page.

@craftzdog
Copy link
Author

Are you logged in with Inkdrop on the app? ipm uses the credentials stored in the app's keystore.

@TaylanTatli
Copy link
Collaborator

Are you logged in with Inkdrop on the app? ipm uses the credentials stored in the app's keystore.

I did, but with different mail. As you can see here, I had created a new account because of that problem.

@craftzdog
Copy link
Author

makes sense. I've migrated the owner info of your plugins to your new account. Can you try it again?

@TaylanTatli
Copy link
Collaborator

Done.

@craftzdog
Copy link
Author

craftzdog commented Mar 12, 2024

I guess the theme isn't compiled to the styles folder.

https://github.com/TaylanTatli/inkdrop-bera-light-ui-theme/tree/master/styles

Have you tested it on the app?

@TaylanTatli
Copy link
Collaborator

Sorry @craftzdog, I will check again.

@TaylanTatli TaylanTatli reopened this Mar 13, 2024
@TaylanTatli
Copy link
Collaborator

Reverted everything. I'll do it all over again.

@craftzdog
Copy link
Author

You can run npm run build before ipm publish.

https://developers.inkdrop.app/guides/create-a-theme#creating-a-ui-theme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants