Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add makefile condition for Linux #18

Closed
wants to merge 1 commit into from

Conversation

yigitsever
Copy link

Fixes #17

Copy link
Owner

@Titor8115 Titor8115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change might cause issue in the future for Linux distributions that don’t symlink -lncursesw and -lncurses. More changes might be needed

@yigitsever
Copy link
Author

yigitsever commented Jun 15, 2020

hmm, I don't have enough experience with that. I could not find something that will not bork building for non-arch distros after searching around either, so closing this for now, thanks for the feedback!

@yigitsever yigitsever closed this Jun 15, 2020
@Titor8115
Copy link
Owner

@yigitsever 😄 That makes two of us. I’m currently looking at how htop handled the issue. I’ll put this as priority.

Thank you so much about feedbacks and stuffs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not compile due to ncurses header path
2 participants