You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Originally mentioned by @rugk in #6 (comment). Users will get many of these erroneous warnings on extensions with several option groups, like the Awesome Emoji Picker, which is confusing for developers creating PRs (#6 (comment)).
// but warn if object was not even frozen, so deev can fix the default settings
if(!Object.isFrozen(value)){
console.warn("The following defined default value of type",typeofvalue,"is not frozen. It is recommend that all default options are frozen.",value);
}
It checks if the objects are not frozen after doing the shallow-copy. They will of course never be frozen after the shallow-copy, which is why this warning always outputs every time the function is called with an object, regardless of whether the object was initially frozen or not...
The text was updated successfully, but these errors were encountered:
Well… the last thing should be no problem, as we use ES2015 or later.
But anyway, also code-style wise it may make sense to rename the variable, so feel free to do so.
Originally mentioned by @rugk in #6 (comment). Users will get many of these erroneous warnings on extensions with several option groups, like the Awesome Emoji Picker, which is confusing for developers creating PRs (#6 (comment)).
This issue is the
unfreezeObject()
function:AddonSettings/AddonSettings.js
Lines 33 to 47 in 7855b9d
It checks if the objects are not frozen after doing the shallow-copy. They will of course never be frozen after the shallow-copy, which is why this warning always outputs every time the function is called with an object, regardless of whether the object was initially frozen or not...
The text was updated successfully, but these errors were encountered: