fix github CI & stuff

workflows/build.yml:
- win32/64: install mingw32/64 gcc on msys (because the default
  gcc installed elsewhere seems to use ucrt, producing incompatible
  fp printf formats.)
tccgen.c:
- cleanup funcs: save any lvalues from return expressions.  Also use
  get_temp_local_var() which however was causing a problem on i386
  because its gfunc_call() removes the arguments from vstack and by
  that defeats the 'in-use'  tracking of get_temp_local_var().  Fixed by:
i386/arm/arm64/x86_64-gen.c:
- in gfunc_call(): save_regs before anything else, fixes
  problems seen in arm64/i386
tccpp.c:
- allow arm asm specific use of '#' in macros
libtcc.c:
- organize -M options, and:
tccpe.c:
- move the subsystem option parsing from libtcc.c
tccelf.c:
- improved error handling in tcc_load_ldscript()
lib/atomic.S:
- TCC_TARGET_... not defined when building the lib
- endbrNN security feature not supported by TCC
tests/tests2/136_atomic_gcc_style.c:
- never use standard assert() in tests

Author: grischka

.github/workflows/build.yml

@@ -29,29 +29,41 @@ jobs:
     - name: make & test tcc (aarch64-osx)
       run: ./configure && make && make test -k
 
-  test-x86-win32:
-    runs-on: windows-2022
-    timeout-minutes: 6
+  test-x86_64-win32:
+    runs-on: windows-2025
+    timeout-minutes: 4
     steps:
     - uses: actions/checkout@v4
     - name: make & test tcc (x86_64-win32)
       shell: cmd
       run: |
+        echo ::group:: setup msys mingw64-gcc
         set MSYS2_PATH_TYPE=inherit
         set MSYSTEM=MINGW64
         set CHERE_INVOKING=yes
+        C:\msys64\usr\bin\bash -l -c "pacman -S --noconfirm mingw-w64-x86_64-gcc"
+        echo ::endgroup::
         C:\msys64\usr\bin\bash -l -c "./configure && make && make test -k"
+
+  test-i386-win32:
+    runs-on: windows-2025
+    timeout-minutes: 4
+    steps:
+    - uses: actions/checkout@v4
     - name: make & test tcc (i386-win32)
       shell: cmd
       run: |
+        echo ::group:: setup msys mingw32-gcc
         set MSYS2_PATH_TYPE=inherit
         set MSYSTEM=MINGW32
         set CHERE_INVOKING=yes
-        C:\msys64\usr\bin\bash -l -c "./configure && make clean all && make test -k"
+        C:\msys64\usr\bin\bash -l -c "pacman -S --noconfirm mingw-w64-i686-gcc"
+        echo ::endgroup::
+        C:\msys64\usr\bin\bash -l -c "./configure && make all && make test -k"
 
   test-armv7-linux:
     runs-on: ubuntu-22.04
-    timeout-minutes: 6
+    timeout-minutes: 8
     steps:
     - uses: actions/checkout@v4
     - uses: uraimo/run-on-arch-action@v3
@@ -69,14 +81,14 @@ jobs:
 
   test-aarch64-linux:
     runs-on: ubuntu-22.04
-    timeout-minutes: 6
+    timeout-minutes: 8
     steps:
     - uses: actions/checkout@v4
     - uses: uraimo/run-on-arch-action@v3
       name: make & test tcc (aarch64-linux)
       with:
         arch: aarch64
-        distro: ubuntu22.04
+        distro: ubuntu24.04
         githubToken: ${{ github.token }}
         install: |
           apt-get update -q -y
@@ -87,7 +99,7 @@ jobs:
 
   test-riscv64-linux:
     runs-on: ubuntu-22.04
-    timeout-minutes: 6
+    timeout-minutes: 8
     steps:
     - uses: actions/checkout@v4
     - uses: uraimo/run-on-arch-action@v3

Makefile

@@ -252,8 +252,11 @@ LDFLAGS += -g
 endif
 
 # convert "include/tccdefs.h" to "tccdefs_.h"
-%_.h : include/%.h conftest.c
-	$S$(CC) -DC2STR $(filter %.c,$^) -o c2str.exe && ./c2str.exe $< $@
+%_.h : include/%.h c2str.exe
+	$S./c2str.exe $< $@
+
+c2str.exe : conftest.c
+	$S$(CC) -DC2STR $< -o $@
 
 # target specific object rule
 $(X)%.o : %.c $(LIBTCC_INC)

arm-gen.c

@@ -1311,10 +1311,6 @@ static int copy_params(int nb_args, struct plan *plan, int todo)
   if (++pass < 2)
     goto again;
 
-  /* Manually free remaining registers since next parameters are loaded
-   * manually, without the help of gv(int). */
-  save_regs(nb_args);
-
   if(todo) {
     o(0xE8BD0000|todo); /* pop {todo} */
     for(pplan = plan->clsplans[CORE_STRUCT_CLASS]; pplan; pplan = pplan->prev) {
@@ -1354,6 +1350,8 @@ void gfunc_call(int nb_args)
     gbound_args(nb_args);
 #endif
 
+  save_regs(nb_args + 1);
+
 #ifdef TCC_ARM_EABI
   if (float_abi == ARM_HARD_FLOAT) {
     variadic = (vtop[-nb_args].type.ref->f.func_type == FUNC_ELLIPSIS);

arm64-gen.c

@@ -997,6 +997,8 @@ ST_FUNC void gfunc_call(int nb_args)
     int variadic = (vtop[-nb_args].type.ref->f.func_type == FUNC_ELLIPSIS);
     int var_nb_arg = n_func_args(&vtop[-nb_args].type);
 
+    save_regs(nb_args + 1);
+
 #ifdef CONFIG_TCC_BCHECK
     if (tcc_state->do_bounds_check)
         gbound_args(nb_args);
@@ -1101,9 +1103,6 @@ ST_FUNC void gfunc_call(int nb_args)
             // value in floating-point registers
             if ((vtop->type.t & VT_BTYPE) == VT_STRUCT) {
                 uint32_t j, sz, n = arm64_hfa(&vtop->type, &sz);
-                // save regs because struct may overwrite previous func call result
-                save_regs(0);
-
                 vtop->type.t = VT_PTR;
                 gaddrof();
                 gv(RC_R30);
@@ -1129,7 +1128,6 @@ ST_FUNC void gfunc_call(int nb_args)
             vswap();
     }
 
-    save_regs(0);
     arm64_gen_bl_or_b(0);
     --vtop;
     if (stack & 0xfff)

i386-gen.c

@@ -406,6 +406,8 @@ ST_FUNC void gfunc_call(int nb_args)
         gbound_args(nb_args);
 #endif
 
+    save_regs(nb_args + 1);
+
     args_size = 0;
     for(i = 0;i < nb_args; i++) {
         if ((vtop->type.t & VT_BTYPE) == VT_STRUCT) {
@@ -463,7 +465,7 @@ ST_FUNC void gfunc_call(int nb_args)
         }
         vtop--;
     }
-    save_regs(0); /* save used temporary registers */
+
     func_sym = vtop->type.ref;
     func_call = func_sym->f.func_call;
     /* fast call case */

lib/atomic.S

@@ -23,8 +23,10 @@
 
 /* ---------------------------------------------- */
 #if defined __i386__
+
+#define endbr32
+
         .text
-        .align  2
 
         .global _(__atomic_load_1)
         .type   _(__atomic_load_1), %function
@@ -297,9 +299,11 @@ _(atomic_flag_clear_explicit):
 #endif //__i386__
 
 /* ---------------------------------------------- */
-#if defined __x86_64__ && !defined TCC_TARGET_PE
+#if defined __x86_64__ && !defined _WIN32
+
+#define endbr64
+
         .text
-        .align  2
 
         .global _(__atomic_load_1)
         .type   _(__atomic_load_1), %function
@@ -508,12 +512,11 @@ _(atomic_flag_clear_explicit):
         ret
 	.size   _(atomic_flag_clear_explicit), .-_(atomic_flag_clear_explicit)
 
-#endif //__x86_64__ && !TCC_TARGET_PE
+#endif //__x86_64__ && !_WIN32
 
 /* ---------------------------------------------- */
-#if defined __x86_64__ && defined TCC_TARGET_PE
+#if defined __x86_64__ && defined _WIN32
         .text
-        .align  2
 
         .global _(__atomic_load_1)
         .type   _(__atomic_load_1), %function
@@ -700,12 +703,11 @@ _(atomic_flag_clear_explicit):
         ret
 	.size   _(atomic_flag_clear_explicit), .-_(atomic_flag_clear_explicit)
 
-#endif //__x86_64__ && TCC_TARGET_PE
+#endif //__x86_64__ && _WIN32
 
 /* ---------------------------------------------- */
 #if defined __arm__
         .text
-        .align  2
 #ifndef __TINYC__
         .arch   armv6k
         .syntax unified
@@ -1496,7 +1498,6 @@ _(atomic_flag_clear_explicit):
 /* ---------------------------------------------- */
 #if defined __aarch64__
         .text
-        .align  2
 
         .global _(__atomic_load_1)
         .type   _(__atomic_load_1), %function
@@ -2115,7 +2116,6 @@ _(atomic_flag_clear_explicit):
 /* ---------------------------------------------- */
 #if defined __riscv
         .text
-        .align  2
 
         .global _(__atomic_load_1)
         .type   _(__atomic_load_1), %function

libtcc.c

@@ -1465,31 +1465,9 @@ static int tcc_set_linker(TCCState *s, const char *optarg)
         } else if (link_option(&o, "stack=")) {
             s->pe_stack_size = strtoul(o.arg, &end, 10);
         } else if (link_option(&o, "subsystem=")) {
-#if defined(TCC_TARGET_I386) || defined(TCC_TARGET_X86_64)
-            if (0==strcmp("native", o.arg)) {
-                s->pe_subsystem = 1;
-            } else if (0==strcmp("console", o.arg)) {
-                s->pe_subsystem = 3;
-            } else if (0==strcmp("gui", o.arg) || 0==strcmp("windows", o.arg)) {
-                s->pe_subsystem = 2;
-            } else if (0==strcmp("posix", o.arg)) {
-                s->pe_subsystem = 7;
-            } else if (0==strcmp("efiapp", o.arg)) {
-                s->pe_subsystem = 10;
-            } else if (0==strcmp("efiboot", o.arg)) {
-                s->pe_subsystem = 11;
-            } else if (0==strcmp("efiruntime", o.arg)) {
-                s->pe_subsystem = 12;
-            } else if (0==strcmp("efirom", o.arg)) {
-                s->pe_subsystem = 13;
-#elif defined(TCC_TARGET_ARM)
-            if (0==strcmp("wince", o.arg)) {
-                s->pe_subsystem = 9;
-#endif
-            } else
+            if (pe_setsubsy(s, o.arg) < 0)
                 goto err;
-#endif /* PE */
-#ifdef TCC_TARGET_MACHO
+#elif defined TCC_TARGET_MACHO
         } else if (link_option(&o, "all_load")) {
 	    s->filetype |= AFF_WHOLE_ARCHIVE;
         } else if (link_option(&o, "force_load=")) {
@@ -1653,11 +1631,10 @@ static const TCCOption tcc_options[] = {
     { "w", TCC_OPTION_w, 0 },
     { "E", TCC_OPTION_E, 0},
     { "M", TCC_OPTION_M, 0},
-    { "MD", TCC_OPTION_MD, 0},
-    { "MF", TCC_OPTION_MF, TCC_OPTION_HAS_ARG },
     { "MM", TCC_OPTION_MM, 0},
-    { "MMD,", TCC_OPTION_MMD, TCC_OPTION_HAS_ARG | TCC_OPTION_NOSEP },
-    { "MMD", TCC_OPTION_MMD, 0},
+    { "MD", TCC_OPTION_MD, TCC_OPTION_HAS_ARG | TCC_OPTION_NOSEP },
+    { "MMD", TCC_OPTION_MMD, TCC_OPTION_HAS_ARG | TCC_OPTION_NOSEP },
+    { "MF", TCC_OPTION_MF, TCC_OPTION_HAS_ARG },
     { "MP", TCC_OPTION_MP, 0},
     { "x", TCC_OPTION_x, TCC_OPTION_HAS_ARG },
     /* tcctools */
@@ -2075,6 +2052,7 @@ PUB_FUNC int tcc_parse_args(TCCState *s, int *pargc, char ***pargv)
         case TCC_OPTION_P:
             s->Pflag = atoi(optarg) + 1;
             break;
+
         case TCC_OPTION_M:
             s->include_sys_deps = 1;
             // fall through
@@ -2084,29 +2062,31 @@ PUB_FUNC int tcc_parse_args(TCCState *s, int *pargc, char ***pargv)
             if (!s->deps_outfile)
                 tcc_set_str(&s->deps_outfile, "-");
             break;
+        case TCC_OPTION_MD:
+            s->include_sys_deps = 1;
+            // fall through
         case TCC_OPTION_MMD:
             s->gen_deps = 1;
             /* usually, only "-MMD" is used */
             /* but the Linux Kernel uses "-MMD,depfile" */
-            if ((optarg) && (*optarg != '\0'))
-                tcc_set_str(&s->deps_outfile, optarg);
-            break;
-        case TCC_OPTION_MD:
-            s->gen_deps = 1;
-            s->include_sys_deps = 1;
-            break;
+            if (*optarg != ',')
+                break;
+            ++optarg;
+            // fall through
         case TCC_OPTION_MF:
             tcc_set_str(&s->deps_outfile, optarg);
             break;
         case TCC_OPTION_MP:
             s->gen_phony_deps = 1;
             break;
+
         case TCC_OPTION_dumpmachine:
             printf("%s\n", dumpmachine_str);
             exit(0);
         case TCC_OPTION_dumpversion:
             printf ("%s\n", TCC_VERSION);
             exit(0);
+
         case TCC_OPTION_x:
             x = 0;
             if (*optarg == 'c')

tcc.h

@@ -1790,6 +1790,7 @@ ST_FUNC void asm_clobber(uint8_t *clobber_regs, const char *str);
 ST_FUNC int pe_load_file(struct TCCState *s1, int fd, const char *filename);
 ST_FUNC int pe_output_file(TCCState * s1, const char *filename);
 ST_FUNC int pe_putimport(TCCState *s1, int dllindex, const char *name, addr_t value);
+ST_FUNC int pe_setsubsy(TCCState *s1, const char *arg);
 #if defined TCC_TARGET_I386 || defined TCC_TARGET_X86_64
 #endif
 #ifdef TCC_TARGET_X86_64

tccelf.c

@@ -3937,7 +3937,7 @@ static int ld_add_file(TCCState *s1, const char filename[])
 {
     if (filename[0] == '-' && filename[1] == 'l')
         return tcc_add_library(s1, filename + 2);
-    {
+    if (CONFIG_SYSROOT[0] != '\0' || !IS_ABSPATH(filename)) {
         /* lookup via library paths */
         int ret = tcc_add_dll(s1, tcc_basename(filename), 0);
         if (ret != FILE_NOT_FOUND)
@@ -3981,27 +3981,27 @@ static int ld_add_file_list(TCCState *s1, const char *cmd)
         } else if (t != LD_TOK_NAME) {
             return tcc_error_noabort("unexpected token '%c'", t);
         } else if (!strcmp(filename, "AS_NEEDED")) {
-            ret = ld_add_file_list(s1, filename);
+            ret |= ld_add_file_list(s1, filename);
         } else if (c == 'I' || c == 'G' || c == 'A') {
-            ret = ld_add_file(s1, filename);
+            ret |= !!ld_add_file(s1, filename);
         }
-        if (ret)
-            return -1;
+        if (ret < 0)
+            return ret;
         t = ld_next(s1, filename, sizeof(filename));
         if (t == ',')
             t = ld_next(s1, filename, sizeof(filename));
     }
-    if (c == 'G' && new_undef_sym(s1, sym_offset))
+    if (c == 'G' && ret == 0 && new_undef_sym(s1, sym_offset))
         goto repeat;
-    return 0;
+    return ret;
 }
 
 /* interpret a subset of GNU ldscripts to handle the dummy libc.so
    files */
 ST_FUNC int tcc_load_ldscript(TCCState *s1, int fd)
 {
     char cmd[64];
-    int t, ret = FILE_NOT_RECOGNIZED;
+    int t, ret = 0, noscript = 1;
     unsigned char *text_ptr, *saved_ptr;
 
     saved_ptr = s1->ld_p;
@@ -4012,19 +4012,22 @@ ST_FUNC int tcc_load_ldscript(TCCState *s1, int fd)
             break;
         if (!strcmp(cmd, "INPUT") ||
             !strcmp(cmd, "GROUP")) {
-            ret = ld_add_file_list(s1, cmd);
+            ret |= ld_add_file_list(s1, cmd);
         } else if (!strcmp(cmd, "OUTPUT_FORMAT") ||
                    !strcmp(cmd, "TARGET")) {
             /* ignore some commands */
-            ret = ld_add_file_list(s1, cmd);
-        } else if (0 == ret) {
+            ret |= ld_add_file_list(s1, cmd);
+        } else if (noscript) {
+            ret = FILE_NOT_RECOGNIZED;
+        } else {
             ret = tcc_error_noabort("unexpected '%s'", cmd);
         }
-        if (ret)
+        if (ret < 0)
             break;
+        noscript = 0;
     }
     tcc_free(text_ptr);
     s1->ld_p = saved_ptr;
-    return ret;
+    return ret < 0 ? ret : -ret;
 }
 #endif /* !ELF_OBJ_ONLY */