tccgen: local scope for types of function parameters

int foo(struct xxx {int x[3];} *p) { ...

We want 'xxx' be visible only inside the function. To get that,
the patch removes the 'sym_push(param)' in xxx-gen.c, and instead
(in tccgen.c:gen_function()) pushes all symbols that were newly
defined during parsing of the parameter list in post_type().

Also,
- decl_initializer_alloc():
  patch existing globals earlier, which updates flex arrays too
- let patch_type() do the 'redefinition' check and FUNC_OLD update

Author: grischka

arm-gen.c

@@ -1493,8 +1493,7 @@ void gfunc_prolog(Sym *func_sym)
       addr = (n + nf + sn) * 4;
       sn += size;
     }
-    sym_push(sym->v & ~SYM_FIELD, type, VT_LOCAL | VT_LVAL,
-             addr + 12);
+    gfunc_set_param(sym, addr + 12, 0);
   }
   last_itod_magic=0;
   leaffunc = 1;

arm64-gen.c

@@ -1242,9 +1242,8 @@ ST_FUNC void gfunc_prolog(Sym *func_sym)
         int off = (a[i] < 16 ? 160 + a[i] / 2 * 8 :
                    a[i] < 32 ? 16 + (a[i] - 16) / 2 * 16 :
                    224 + ((a[i] - 32) >> 1 << 1));
-        sym_push(sym->v & ~SYM_FIELD, &sym->type,
-                 (a[i] & 1 ? VT_LLOCAL : VT_LOCAL) | VT_LVAL,
-                 off);
+
+        gfunc_set_param(sym, off, a[i] & 1);
 
         if (a[i] < 16) {
             int align, size = type_size(&sym->type, &align);

c67-gen.c

@@ -1968,7 +1968,7 @@ void gfunc_prolog(Sym *func_sym)
     /* define parameters */
     while ((sym = sym->next) != NULL) {
 	type = &sym->type;
-	sym_push(sym->v & ~SYM_FIELD, type, VT_LOCAL | VT_LVAL, addr);
+	gfunc_set_param(sym, addr, 0);
 	size = type_size(type, &align);
 	size = (size + 3) & ~3;
 

i386-gen.c

@@ -578,8 +578,7 @@ ST_FUNC void gfunc_prolog(Sym *func_sym)
             param_addr = addr;
             addr += size;
         }
-        sym_push(sym->v & ~SYM_FIELD, type,
-                 VT_LOCAL | VT_LVAL, param_addr);
+        gfunc_set_param(sym, param_addr, 0);
         param_index++;
     }
     func_ret_sub = 0;

riscv64-gen.c

@@ -833,9 +833,7 @@ ST_FUNC void gfunc_prolog(Sym *func_sym)
                 }
             }
         }
-        sym_push(sym->v & ~SYM_FIELD, &sym->type,
-                 (byref ? VT_LLOCAL : VT_LOCAL) | VT_LVAL,
-                 param_addr);
+        gfunc_set_param(sym, param_addr, byref);
     }
     func_va_list_ofs = addr;
     num_va_regs = 0;

tcc.h

@@ -1506,6 +1506,7 @@ ST_FUNC int classify_x86_64_va_arg(CType *ty);
 ST_FUNC void gbound_args(int nb_args);
 ST_DATA int func_bound_add_epilog;
 #endif
+ST_FUNC Sym *gfunc_set_param(Sym *s, int c, int byref);
 
 /* ------------ tccelf.c ------------ */
 
@@ -1856,7 +1857,7 @@ ST_FUNC void tcc_debug_eincl(TCCState *s1);
 ST_FUNC void tcc_debug_newfile(TCCState *s1);
 
 ST_FUNC void tcc_debug_line(TCCState *s1);
-ST_FUNC void tcc_add_debug_info(TCCState *s1, int param, Sym *s, Sym *e);
+ST_FUNC void tcc_add_debug_info(TCCState *s1, Sym *s, Sym *e);
 ST_FUNC void tcc_debug_funcstart(TCCState *s1, Sym *sym);
 ST_FUNC void tcc_debug_prolog_epilog(TCCState *s1, int value);
 ST_FUNC void tcc_debug_funcend(TCCState *s1, int size);

tccdbg.c

@@ -1625,7 +1625,7 @@ static void tcc_get_debug_info(TCCState *s1, Sym *s, CString *result)
 
         t = t->type.ref;
 	debug_type = tcc_debug_find(s1, t, 0);
-        if (debug_type == -1) {
+        if (debug_type == -1 && t->c >= 0) {
             debug_type = tcc_debug_add(s1, t, 0);
             cstr_new (&str);
             cstr_printf (&str, "%s:T%d=%c%d",
@@ -1664,7 +1664,7 @@ static void tcc_get_debug_info(TCCState *s1, Sym *s, CString *result)
         Sym *e = t = t->type.ref;
 
 	debug_type = tcc_debug_find(s1, t, 0);
-	if (debug_type == -1) {
+	if (debug_type == -1 && t->c >= 0) {
 	    debug_type = tcc_debug_add(s1, t, 0);
             cstr_new (&str);
             cstr_printf (&str, "%s:T%d=e",
@@ -1741,7 +1741,7 @@ static int tcc_get_dwarf_info(TCCState *s1, Sym *s)
     if ((type & VT_BTYPE) == VT_STRUCT) {
         t = t->type.ref;
 	debug_type = tcc_debug_find(s1, t, 1);
-	if (debug_type == -1) {
+	if (debug_type == -1 && t->c >= 0) {
 	    int pos_sib = 0, i, *pos_type;
 
 	    debug_type = tcc_debug_add(s1, t, 1);
@@ -1819,7 +1819,7 @@ static int tcc_get_dwarf_info(TCCState *s1, Sym *s)
     else if (IS_ENUM(type)) {
         t = t->type.ref;
 	debug_type = tcc_debug_find(s1, t, 1);
-	if (debug_type == -1) {
+	if (debug_type == -1 && t->c >= 0) {
 	    int pos_sib, pos_type;
 	    Sym sym = {0}; sym.type.t = VT_INT | (type & VT_UNSIGNED);
 
@@ -2090,14 +2090,16 @@ static void tcc_debug_finish (TCCState *s1, struct _debug_info *cur)
     }
 }
 
-ST_FUNC void tcc_add_debug_info(TCCState *s1, int param, Sym *s, Sym *e)
+ST_FUNC void tcc_add_debug_info(TCCState *s1, Sym *s, Sym *e)
 {
     CString debug_str;
+    int param;
 
     if (!(s1->do_debug & 2))
         return;
 
     cstr_new (&debug_str);
+    param = !e;
     for (; s != e; s = s->prev) {
         if (!s->v || (s->r & VT_VALMASK) != VT_LOCAL)
             continue;