Merge pull request #7 from TimInTech/codex/check-and-improve-file-upload-issues

Fix shellcheck warnings

Author: TimInTech

.gitattributes

@@ -0,0 +1 @@
+* text=auto

bedrock_helper.sh

@@ -1,2 +1,3 @@
 #!/bin/bash
+set -euo pipefail
 echo "Manual Bedrock update required. Visit official Mojang page to download."

setup_bedrock.sh

@@ -4,15 +4,15 @@
 # Tested on Debian 11/12 and Ubuntu 24.04
 # Author: TimInTech
 
-set -e  # Exit on any error
+set -euo pipefail  # Exit on error, unset variable, or failed pipeline
 
 # Install required dependencies
 sudo apt update && sudo apt upgrade -y
 sudo apt install -y unzip wget screen curl
 
 # Set up server directory
 sudo mkdir -p /opt/minecraft-bedrock
-sudo chown $(whoami):$(whoami) /opt/minecraft-bedrock
+sudo chown "$(whoami)":"$(whoami)" /opt/minecraft-bedrock
 cd /opt/minecraft-bedrock
 
 # Fetch the latest Bedrock server URL
@@ -25,10 +25,7 @@ if [[ -z "$LATEST_URL" ]]; then
 fi
 
 echo "Downloading Minecraft Bedrock Server from: $LATEST_URL"
-wget -O bedrock-server.zip "$LATEST_URL"
-
-# Check if the download was successful
-if [[ $? -ne 0 ]]; then
+if ! wget -O bedrock-server.zip "$LATEST_URL"; then
   echo "ERROR: Download failed. Check your internet connection."
   exit 1
 fi

setup_minecraft.sh

@@ -4,7 +4,7 @@
 # Tested on Debian 11/12 and Ubuntu 24.04
 # Author: TimInTech
 
-set -e  # Exit script on error
+set -euo pipefail  # Exit script on error, undefined variable, or failed pipeline
 
 # Install required dependencies
 sudo apt update && sudo apt upgrade -y
@@ -18,12 +18,12 @@ fi
 
 # Set up server directory
 sudo mkdir -p /opt/minecraft
-sudo chown $(whoami):$(whoami) /opt/minecraft
+sudo chown "$(whoami)":"$(whoami)" /opt/minecraft
 cd /opt/minecraft
 
 # Fetch the latest PaperMC version
 LATEST_VERSION=$(curl -s https://api.papermc.io/v2/projects/paper | jq -r '.versions | last')
-LATEST_BUILD=$(curl -s https://api.papermc.io/v2/projects/paper/versions/$LATEST_VERSION | jq -r '.builds | last')
+LATEST_BUILD=$(curl -s https://api.papermc.io/v2/projects/paper/versions/"$LATEST_VERSION" | jq -r '.builds | last')
 
 # Validate if version and build numbers were retrieved
 if [[ -z "$LATEST_VERSION" || -z "$LATEST_BUILD" ]]; then

setup_minecraft_lxc.sh

@@ -4,6 +4,9 @@
 # Tested on Debian 11/12 and Ubuntu 24.04
 # Author: TimInTech
 
+
+set -euo pipefail
+
 # Update package lists and install required dependencies
 apt update && apt upgrade -y
 apt install -y screen wget curl jq unzip
@@ -15,11 +18,11 @@ if ! apt install -y openjdk-21-jre-headless; then
 fi
 
 # Create the Minecraft server directory
-mkdir -p /opt/minecraft && cd /opt/minecraft
+mkdir -p /opt/minecraft && cd /opt/minecraft || exit
 
 # Fetch the latest PaperMC version
 LATEST_VERSION=$(curl -s https://api.papermc.io/v2/projects/paper | jq -r '.versions | last')
-LATEST_BUILD=$(curl -s https://api.papermc.io/v2/projects/paper/versions/$LATEST_VERSION | jq -r '.builds | last')
+LATEST_BUILD=$(curl -s https://api.papermc.io/v2/projects/paper/versions/"$LATEST_VERSION" | jq -r '.builds | last')
 
 # Validate if the version and build exist
 if [[ -z "$LATEST_VERSION" || -z "$LATEST_BUILD" ]]; then

update.sh

@@ -1,9 +1,11 @@
 #!/bin/bash
 
+set -euo pipefail
+
 cd /opt/minecraft || exit 1
 
 LATEST_VERSION=$(curl -s https://api.papermc.io/v2/projects/paper | jq -r '.versions | last')
-LATEST_BUILD=$(curl -s https://api.papermc.io/v2/projects/paper/versions/$LATEST_VERSION | jq -r '.builds | last')
+LATEST_BUILD=$(curl -s https://api.papermc.io/v2/projects/paper/versions/"$LATEST_VERSION" | jq -r '.builds | last')
 
 wget -O server.jar "https://api.papermc.io/v2/projects/paper/versions/$LATEST_VERSION/builds/$LATEST_BUILD/downloads/paper-$LATEST_VERSION-$LATEST_BUILD.jar"