Skip to content

Commit 839477c

Browse files
authored
Change Openslide Drive Path for Windows (#131)
* Testing C dir * Update Readme installation directions for openslide * Define output for coverage
1 parent 0c8d80c commit 839477c

File tree

3 files changed

+25
-6
lines changed

3 files changed

+25
-6
lines changed

.github/workflows/ci.yml

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,10 @@ jobs:
1919

2020
env:
2121
run_coverage: ${{ github.ref == 'refs/heads/main' }}
22-
22+
23+
outputs:
24+
coverage: ${{ steps.stats.outputs.coverage }}
25+
2326
steps:
2427
- uses: actions/checkout@v2
2528

@@ -46,8 +49,8 @@ jobs:
4649
choco install wget --no-progress
4750
wget https://github.com/openslide/openslide-winbuild/releases/download/v20221217/openslide-win64-20221217.zip
4851
7z x openslide-win64-20221217.zip -oD:\openslide\
49-
mklink /D D:\openslide-win64\ D:\openslide\openslide-win64-20221217\
50-
cd D:\openslide-win64\
52+
mklink /D C:\openslide-win64\ D:\openslide\openslide-win64-20221217\
53+
cd C:\openslide-win64\
5154
dir
5255
set openslide_path=%cd%
5356
echo %openslide_path%
@@ -74,7 +77,7 @@ jobs:
7477
pytest -v --cov=tiledb --cov-report=term-missing --durations=0 tests/ > coverage.txt
7578
exit_code=$?
7679
TEST_COVERAGE="$(grep '^TOTAL' coverage.txt | awk -v N=4 '{print $N}')"
77-
echo "COVERAGE=$TEST_COVERAGE" >> $GITHUB_OUTPUT
80+
echo "coverage=$TEST_COVERAGE" >> $GITHUB_OUTPUT
7881
exit $exit_code
7982
if: ${{ matrix.sys.os != 'windows-latest' }}
8083

@@ -101,6 +104,6 @@ jobs:
101104
gistID: 32d48185733a4e7375e80e3e35fab452
102105
filename: gist_bioimg.json
103106
label: Test Coverage
104-
message: ${{ steps.stats.outputs.COVERAGE }}
107+
message: ${{ steps.stats.outputs.coverage }}
105108
color: green
106109
namedLogo: pytest

README.md

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,22 @@ Python package for:
3838

3939
pip install -e '.[full]'
4040

41+
## Windows Installation
42+
43+
After installing `Openslide` you should make sure that you create a link between your installation path and
44+
the following default path `C:\openslide-win64\ `.
45+
46+
```cmd
47+
mklink /D C:\openslide-win64\ [your-installation-path]\openslide-win64-20221217\
48+
```
49+
50+
You can install the latest versions of `Openslide` for windows using the pre-built packages
51+
found in the project's github page:
52+
`https://github.com/openslide/openslide-bin/releases`
53+
54+
or in their website:
55+
`https://openslide.org/download/`
56+
4157

4258
## Examples
4359
How to convert imaging data from standard biomedical formats to group of TileDB arrays.

tiledb/bioimg/converters/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
DATASET_TYPE = "bioimg"
33
DEFAULT_SCRATCH_SPACE = "/dev/shm"
44
# Windows use only
5-
WIN_OPENSLIDE_PATH = r"D:\openslide-win64\bin"
5+
WIN_OPENSLIDE_PATH = r"C:\openslide-win64\bin"

0 commit comments

Comments
 (0)