-
Notifications
You must be signed in to change notification settings - Fork 478
feat(metrics): add opentelemetry support #575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: ahkui <[email protected]> ThreeDotsLabs#574
a1f41a2 to
5470970
Compare
Signed-off-by: ahkui <[email protected]> ThreeDotsLabs#574
|
Hi @roblaszczak and @m110, Could you please help review this PR when you have a moment? Thanks! |
Signed-off-by: ahkui <[email protected]>
4182b09 to
c51f8a9
Compare
|
We had this issue with OpenTelemtry in many projects: open-telemetry/opentelemetry-go#4476 To avoid that it would be good to move OpenTelemetry implementation to a separate package, with a separate go.mod. So the main go.mod won't be affected. I would moving those changes to a separate Do you feel you'll have time for that @ahkui? Let us know! |
@roblaszczak yes, i can handle that the new pkg i will move to |
Hey, I discussed it with @m110 and since it looks orthogonal to the So I would suggest |
Signed-off-by: ahkui [email protected]
#574
Motivation / Background
Implement metrics collection using the OpenTelemetry MeterProvider
Detail
Implement metrics collection using the OpenTelemetry MeterProvider
Alternative approaches considered (if applicable)
Checklist
The resources of our team are limited. There are a couple of things that you can do to help us merge your PR faster:
make up.make test_shortfor a quick check.make test.