Support single-request multipart upload for setting metadata #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe it would make sense to provide a similar interface to the create_streamed function, by adding a create_streamed_with method ? |
|
Yep, that's a good idea! Though I am not sure if I'll be able to quickly get back to it just yet. There has been some reprioritization at work and it may take a while for me to make edits. I'll try, but if someone else has immediate need for it please go ahead.. Another thought is to at least get this in and open another PR to support the streamed api. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ThouCheese Hi could you take a look at this PR and suggest any edits etc? This resolves this issue .
I've added tests and verified that the tests are passing for both the async and the sync version. Thanks!