Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creation of bucket with Lifecycle conditions incomplete #82

Open
ralpha opened this issue Aug 9, 2021 · 2 comments
Open

Creation of bucket with Lifecycle conditions incomplete #82

ralpha opened this issue Aug 9, 2021 · 2 comments

Comments

@ralpha
Copy link

ralpha commented Aug 9, 2021

Some conditions are not available in Condition.
https://cloud.google.com/storage/docs/json_api/v1/buckets#lifecycle
https://cloud.google.com/storage/docs/lifecycle#conditions
These are missing:

  • customTimeBefore
  • daysSinceCustomTime
  • daysSinceNoncurrentTime
  • noncurrentTimeBefore

Also separate:
I think the documentation for ActionType::Delete is incorrect I think it does not delete the bucket but the objects inside of it.
https://cloud.google.com/storage/docs/lifecycle#delete
Screenshot from 2021-08-09 17-20-22

I can make a PR for this (and other issues) at some point in the future, but just an issue to keep track of it for now.

@ralpha
Copy link
Author

ralpha commented Aug 9, 2021

Also Condition does not implement Default.

@ThouCheese
Copy link
Owner

A PR for this is definitely welcome! Feel free to submit one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants