-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add if-match (and other optional headers) to create object #40
Comments
Sure this seems like a reasonable enhancement. Two issues come to mind about implementing this, namely that it requires a breaking change to almost every function in the library if we want to do something like |
I would love this as well as I need if-match. @ThouCheese It won't have to be a breaking change. We can also provide new functions like |
Sure but the downside would then be that we have to duplicate almost all functions: |
If you're breaking the API at some point I recommend using the builder pattern for calls. It takes more effort to implement but is more resilient in the long term, allowing the API to expand in the future without breaking the contract. |
It would be useful for optional headers (especially if-match) to be implemented so that logic can be on the server-side. Ideally, all optional headers should be accessible in this library to support full functionality of Google Cloud's JSON API. I just happen to need if-match and if-none-match for my use case.
The text was updated successfully, but these errors were encountered: