Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PHP 8.1 better #94

Open
xvilo opened this issue Aug 15, 2022 · 3 comments
Open

Support PHP 8.1 better #94

xvilo opened this issue Aug 15, 2022 · 3 comments
Assignees
@ThomasWeinert

Comments

@xvilo
Copy link

xvilo commented Aug 15, 2022

Currently this library emits a lot of warnings on PHP. An example:

Deprecated: Return type of FluentDOM\Serializer\Factory\Group::offsetGet($offset) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /src/fluentdom/fluentdom/src/FluentDOM/Serializer/Factory/Group.php on line 75

These should be fixed
@ThomasWeinert ThomasWeinert self-assigned this Aug 31, 2022
@beerendlauwers
Copy link

@ThomasWeinert Do you happen to have time for this? This interferes a lot with our automated code checking.

@Rikardsen
Copy link

I would also like FluentDOM to work with PHP 8

@ThomasWeinert
Copy link
Owner

ThomasWeinert commented Oct 22, 2023 •
edited
Loading

Please check the refactor/php8 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomasWeinert ThomasWeinert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ThomasWeinert @xvilo @beerendlauwers @Rikardsen