Removed TODOs, implemented some, fixed code smells.

Author: haydenmcp

.circleci/config.yml

@@ -41,8 +41,9 @@ jobs:
         - setup_remote_docker:
             version: 20.10.7
         - login_docker
-        - install_and_login_doctl
-        - kubernetes/install-kubectl
+        - k8s/install
+        - k8s/initialize:
+            cluster: predecos-kubernetes-cluster
         - kubernetes/delete-resource:
             now: true
             resource-names: mongodb-deployment
@@ -51,7 +52,7 @@ jobs:
         - kubernetes/create-or-update-resource:
             get-rollout-status: true
             resource-file-path: ./packages/deep-microservice-collection/k8s/mongodb-deployment.yml
-            resource-name: mongodb-deployment
+            resource-name: deployment/mongodb-deployment
             show-kubectl-command: true
 
     deploy_postgres:
@@ -65,8 +66,9 @@ jobs:
         - setup_remote_docker:
             version: 20.10.7
         - login_docker
-        - install_and_login_doctl
-        - kubernetes/install-kubectl
+        - k8s/install
+        - k8s/initialize:
+            cluster: predecos-kubernetes-cluster
         - kubernetes/delete-resource:
             now: true
             resource-names: postgres-deployment

packages/deep-microservice-analysis/src/index.mjs

@@ -66,6 +66,6 @@ const startApolloServer = async () => {
   );
 };
 
-startApolloServer().then(() => { }, (reason) => {
+startApolloServer().then(() => { /* Do nothing */ }, (reason) => {
   logger.error(`An Error Occurred: ${JSON.stringify(reason)}`);
 });

packages/deep-microservice-analysis/src/logging-plugin.mjs

@@ -10,13 +10,13 @@ const loggingPlugin = {
       return {
         // Fires whenever Apollo Server will parse a GraphQL
         // request to create its associated document AST.
-        async parsingDidStart(requestContext) {
+        async parsingDidStart() {
           logger.debug('Parsing started.');
         },
 
         // Fires whenever Apollo Server will validate a
         // request's document AST against your GraphQL schema.
-        async validationDidStart(requestContext) {
+        async validationDidStart() {
           logger.debug('Validation started.');
         },
 

packages/deep-microservice-collection/src/index.mjs

@@ -8,7 +8,6 @@ import {getLogger} from './get-logger.mjs'
 import {getPublicIP} from './get-public-ip.mjs';
 import {loggingPlugin} from './logging-plugin.mjs';
 import {MongoClient} from 'mongodb';
-import os from 'os';
 import process from 'process';
 import {resolvers} from './resolvers.mjs';
 import {typeDefs} from './schema.mjs';
@@ -43,7 +42,6 @@ const startApolloServer = async () => {
   console.log("Connected successfully to server");
 
   const twitterAPI = new TwitterAPI();
-  // TODO: remove admin
   const tweetStore = new TweetStore(mongoClient.db('admin').collection('tweets'));
   const collectionService = new CollectionService(twitterAPI, tweetStore, logger);
 
@@ -63,9 +61,6 @@ const startApolloServer = async () => {
     // of the schema. This can be dangerous in production. However, these services are intended to be visible so this isn't
     // currently an issue.
     introspection: true,
-
-    // TODO: Disable this later
-    playground: isProduction
   });
   await server.start();
 
@@ -85,7 +80,6 @@ const startApolloServer = async () => {
   server.applyMiddleware({
     app,
     cors: {
-      // TODO: Remove localhost from prod deployments. Security.
       origin: allowedOrigins,
       methods: 'GET,HEAD,PUT,PATCH,POST,DELETE,OPTIONS,CONNECT,TRACE',
       credentials: true,
@@ -101,6 +95,6 @@ const startApolloServer = async () => {
   );
 };
 
-startApolloServer().then(() => { }, (reason) => {
+startApolloServer().then(() => { /* Do nothing */ }, (reason) => {
   logger.error(`An Error Occurred: ${JSON.stringify(reason)}`);
 });

packages/deep-microservice-collection/src/logging-plugin.mjs

@@ -10,13 +10,13 @@ const loggingPlugin = {
       return {
         // Fires whenever Apollo Server will parse a GraphQL
         // request to create its associated document AST.
-        async parsingDidStart(requestContext) {
+        async parsingDidStart() {
           logger.debug('Parsing started.');
         },
 
         // Fires whenever Apollo Server will validate a
         // request's document AST against your GraphQL schema.
-        async validationDidStart(requestContext) {
+        async validationDidStart() {
           logger.debug('Validation started.');
         },
 

packages/deep-microservice-gateway/src/index.mjs

@@ -83,6 +83,6 @@ const startGatewayService = async () => {
   );
 };
 
-startGatewayService().then(() => { }, (reason) => {
+startGatewayService().then(() => { /* Do nothing */ }, (reason) => {
   logger.error(`An Error Occurred: ${JSON.stringify(reason)}`);
 });

packages/deep-template-analyzer/rollup.config.mjs

@@ -1,7 +1,6 @@
 import merge from 'deepmerge';
 
 // NOTE: The relative path below is required otherwise the build errors out.
-// TODO: Fix
 import baseConfig from "../../node_modules/@thinkdeep/tools/rollup.config.mjs";
 
 export default merge(baseConfig, {