From 7b857ced33b588cee1d5b44768a7daf82c560af3 Mon Sep 17 00:00:00 2001 From: ThibaultBee <37510686+ThibaultBee@users.noreply.github.com> Date: Tue, 21 Jan 2025 11:11:19 +0100 Subject: [PATCH] fix(core): camera: fix mirroring in landscape with front facing camera --- .../core/elements/sources/video/camera/CameraInfoProvider.kt | 3 ++- .../streampack/core/streamers/single/CameraSingleStreamer.kt | 4 ---- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/core/src/main/java/io/github/thibaultbee/streampack/core/elements/sources/video/camera/CameraInfoProvider.kt b/core/src/main/java/io/github/thibaultbee/streampack/core/elements/sources/video/camera/CameraInfoProvider.kt index fea38fd8..b45d4e96 100644 --- a/core/src/main/java/io/github/thibaultbee/streampack/core/elements/sources/video/camera/CameraInfoProvider.kt +++ b/core/src/main/java/io/github/thibaultbee/streampack/core/elements/sources/video/camera/CameraInfoProvider.kt @@ -44,7 +44,8 @@ class CameraInfoProvider( val isFrontFacing: Boolean get() = context.getFacingDirection(cameraId) == CameraCharacteristics.LENS_FACING_FRONT - override val isMirror = false + override val isMirror: Boolean + get() = isFrontFacing @IntRange(from = 0, to = 359) override fun getRelativeRotationDegrees( diff --git a/core/src/main/java/io/github/thibaultbee/streampack/core/streamers/single/CameraSingleStreamer.kt b/core/src/main/java/io/github/thibaultbee/streampack/core/streamers/single/CameraSingleStreamer.kt index 60d89d0e..7eafac23 100644 --- a/core/src/main/java/io/github/thibaultbee/streampack/core/streamers/single/CameraSingleStreamer.kt +++ b/core/src/main/java/io/github/thibaultbee/streampack/core/streamers/single/CameraSingleStreamer.kt @@ -153,10 +153,6 @@ open class CameraSingleStreamer( return CameraStreamerConfigurationInfo(endpointInfo) } - override fun isMirroringRequired(): Boolean { - return cameraSource.infoProvider.isFrontFacing - } - /** * Sets a preview surface. */