Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined variable error after skipping the wizard during initial setup #462

Open
Pupix opened this issue Jul 15, 2024 · 1 comment
Open

Comments

@Pupix
Copy link

Pupix commented Jul 15, 2024

Repro steps:

  1. Do a fresh install
  2. Skip setup wizard
  3. Go to Venues
  4. Scroll down where the map is
  5. See undefined error

The problem is in lines such as this:

if ( ! is_numeric( $latitude ) || ! is_numeric( $longitude ) ) :

where if there are no venues, the used variables ($latitude, $longitude, $address) never get assigned.

I believe order of operations should be inverted. First assign a default value to the variables and then override with the last venue if possible.

I haven't checked if the same issue appears somewhere else, but probably.

Cheers

@savvasha
Copy link
Collaborator

Hi there @Pupix ,

It should be fixed with the following commit:
404f9aa

Thanks,
Savvas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants