fix: Add static cast

Stubbjax · Stubbjax · commit a2135606db5f · 2026-03-18T21:18:51.000+11:00
diff --git a/Generals/Code/GameEngine/Source/Common/RTS/Player.cpp b/Generals/Code/GameEngine/Source/Common/RTS/Player.cpp
@@ -1735,7 +1735,7 @@ void Player::setObjectsEnabled(AsciiString templateTypeToAffect, Bool enable)
 //=============================================================================
 static void cancelUpgradeInProduction(Object* obj, void* userData)
 {
-	const UpgradeTemplate* upgradeTemplate = (const UpgradeTemplate*)userData;
+	const UpgradeTemplate* upgradeTemplate = static_cast<const UpgradeTemplate*>(userData);
 	ProductionUpdateInterface* pui = ProductionUpdate::getProductionUpdateInterfaceFromObject(obj);
 
 	if (pui && pui->isUpgradeInQueue(upgradeTemplate))
diff --git a/GeneralsMD/Code/GameEngine/Source/Common/RTS/Player.cpp b/GeneralsMD/Code/GameEngine/Source/Common/RTS/Player.cpp
@@ -2119,7 +2119,7 @@ void Player::setObjectsEnabled(AsciiString templateTypeToAffect, Bool enable)
 //=============================================================================
 static void cancelUpgradeInProduction(Object* obj, void* userData)
 {
-	const UpgradeTemplate* upgradeTemplate = (const UpgradeTemplate*)userData;
+	const UpgradeTemplate* upgradeTemplate = static_cast<const UpgradeTemplate*>(userData);
 	ProductionUpdateInterface* pui = ProductionUpdate::getProductionUpdateInterfaceFromObject(obj);
 
 	if (pui && pui->isUpgradeInQueue(upgradeTemplate))

Original file line number	Diff line number	Diff line change
`@@ -1735,7 +1735,7 @@ void Player::setObjectsEnabled(AsciiString templateTypeToAffect, Bool enable)`
`1735`	`1735`	`//=============================================================================`
`1736`	`1736`	`static void cancelUpgradeInProduction(Object* obj, void* userData)`
`1737`	`1737`	`{`
`1738`		`- const UpgradeTemplate* upgradeTemplate = (const UpgradeTemplate*)userData;`
	`1738`	`+ const UpgradeTemplate* upgradeTemplate = static_cast<const UpgradeTemplate*>(userData);`
`1739`	`1739`	`ProductionUpdateInterface* pui = ProductionUpdate::getProductionUpdateInterfaceFromObject(obj);`
`1740`	`1740`
`1741`	`1741`	`if (pui && pui->isUpgradeInQueue(upgradeTemplate))`
Original file line number	Diff line number	Diff line change
`@@ -2119,7 +2119,7 @@ void Player::setObjectsEnabled(AsciiString templateTypeToAffect, Bool enable)`
`2119`	`2119`	`//=============================================================================`
`2120`	`2120`	`static void cancelUpgradeInProduction(Object* obj, void* userData)`
`2121`	`2121`	`{`
`2122`		`- const UpgradeTemplate* upgradeTemplate = (const UpgradeTemplate*)userData;`
	`2122`	`+ const UpgradeTemplate* upgradeTemplate = static_cast<const UpgradeTemplate*>(userData);`
`2123`	`2123`	`ProductionUpdateInterface* pui = ProductionUpdate::getProductionUpdateInterfaceFromObject(obj);`
`2124`	`2124`
`2125`	`2125`	`if (pui && pui->isUpgradeInQueue(upgradeTemplate))`