Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default all searches to the TPDB movies #161

Open
thedesi1 opened this issue Jan 20, 2023 · 7 comments
Open

Default all searches to the TPDB movies #161

thedesi1 opened this issue Jan 20, 2023 · 7 comments

Comments

@thedesi1
Copy link

Enhancement to namer so that a flag is set in config file and all the queries go to TPDB movies vs trying to also search Scenes

@thedesi1
Copy link
Author

This is already implemented in the JF TPDB plugin

@4c0d3r
Copy link
Collaborator

4c0d3r commented Jan 25, 2023

This will have to work differently.

Namer needs another regex parser for movie formats.... parse as scene first, if that fails parse as movie (name - year.ext) -- ignore matching on site.

Namer likely should decide which data source to query first based which parser succeeds. The jellyfin plugin likely should be left to match scenes first, and then movies if you are using namer's default name output pattern of site - data - name. Which I don't think you are.

But keep in mind it's not about just your use case, but other's as well -- and it's up in the air if we should force movies and scenes to be in different libraries in jelly/plex or in one. I happen to keep them all in one folder.

@thedesi1
Copy link
Author

thedesi1 commented Jan 25, 2023

I agree, from my experience in Stash world, most folks are keeping them separate and I am asking to use default which is the current scenario or option to separate it like JF, which works perfectly fine. Just for the reference, 98% of the movies that are collected from various sources dont match today and whatever match is incorrect, I have tested it with 1000+ titles.

@thedesi1
Copy link
Author

also the manual mode that went with #170 will work for my use case so not very important to implement this.

@4c0d3r
Copy link
Collaborator

4c0d3r commented Jan 25, 2023

The matching may work if "name - year.ext" searching were a thing. Glad 170 eases your current needs, but if namer ever supports movies fully I'd want to do it right. Not sure what that means yet. Is "name - year.ext" really that common? Or is site-date-name.ext more common? Should all the plugins be updated to support "name-year.ext", or should namer always output sites-date-name.ext instead (so the plugins just work)? I don't know if we know the right answers yet.

@thedesi1
Copy link
Author

You are right, I have been trying to figure out myself, each movie has multiple years and multiple studios, exactly same movie, tpdb needs to dedupe and do something like what I proposed in discord:

One Movie - Multiple Studios
One Movie - Multiple release dates by Studios

@thedesi1
Copy link
Author

What's been working 99% time is this for me:
name} ({year})/{name} ({year}) - {site} - {date} - {resolution}.{ext}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants