You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now, sol_lua_check and sol::stack::check work by using a handler-based approach that invokes some sort of error handling operation, which is expected to jump or throw or terminate. These are not useful modes of continuation, and definitively cause excessive failures that are hard to track (see #1144, #1174, #1183, #1078, #1072, #965, #1038 and more).
The fix for this is to change how sol::stack::check, sol_lua_check, and the error handlers work. This can also be used to improve the situation for returning if an error actually happens checking, and make the protect and code more streamlined. It will look like so:
This means that the bool return from before is no longer viable. As a general upgrade path, we will likely allow old code to work. But, this might mean fundamentally destroying the way sol_lua_check_get has to operate, since we need to return an error better rather than always simply panicking in a handler.
The text was updated successfully, but these errors were encountered:
Right now,
sol_lua_check
andsol::stack::check
work by using a handler-based approach that invokes some sort of error handling operation, which is expected to jump or throw or terminate. These are not useful modes of continuation, and definitively cause excessive failures that are hard to track (see #1144, #1174, #1183, #1078, #1072, #965, #1038 and more).The fix for this is to change how
sol::stack::check
,sol_lua_check
, and the error handlers work. This can also be used to improve the situation for returning if an error actually happens checking, and make theprotect
and code more streamlined. It will look like so:This means that the
bool
return from before is no longer viable. As a general upgrade path, we will likely allow old code to work. But, this might mean fundamentally destroying the waysol_lua_check_get
has to operate, since we need to return an error better rather than always simply panicking in a handler.The text was updated successfully, but these errors were encountered: