Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HEIC Support for EXIF data #44

Closed
alexhellmann opened this issue Jan 11, 2021 · 18 comments
Closed

HEIC Support for EXIF data #44

alexhellmann opened this issue Jan 11, 2021 · 18 comments
Labels
enhancement New feature or request

Comments

@alexhellmann
Copy link

Hello,
is it possible to to add heic support? I used for some years an iPhone and the the photos are in heic format. But the script supports only jpg and tif.

@TheLastGimbus
Copy link
Owner

TheLastGimbus commented Jan 11, 2021

Huh, this is the thing of piexif library that it uses

But reading/writing exif is only one of few ways that this script uses to get correct date - I am planning to improve "finding correct json for photo" soon, so it probably won't need to read exif anymore to set correct "file modified time"

Edit: hMatoba/Piexif#104

@tundrablasen
Copy link

HEIC support would really be cool. Currently you script is not helpful for most of the new devices. iPhones use heic since the iPhone 8 (4 years ago) as default. Samsung Galaxy flagships use HEIC since the last 2 years as default.

for me most of my Photo Library is therefore in HEIC.

i saw that some forks already implemented heic support. Maybe you can consider that too

@TheLastGimbus
Copy link
Owner

Oh, can you show me those forks? This is interesting

not helpful for most of the new devices

But do your exported phots don't have exif? Inserting exif should be only needed when you edited it/it was stripped - do iPhones/Google Photos strip it?

@tundrablasen
Copy link

tundrablasen commented Jan 24, 2021

Oh, can you show me those forks? This is interesting

not helpful for most of the new devices

But do your exported phots don't have exif? Inserting exif should be only needed when you edited it/it was stripped - do iPhones/Google Photos strip it?

I clicked through the forks shown on your GitHub. One had heic support via a specific library.

It seems that not all my photos had correct meta data. I imported it to iCloud and didn’t had the same pictures with the same time stamps

@TheLastGimbus
Copy link
Owner

One had heic support via a specific library

I want to see this, just which one?

@TheLastGimbus TheLastGimbus pinned this issue Jan 29, 2021
@TheLastGimbus TheLastGimbus added the enhancement New feature or request label Jan 29, 2021
@TheLastGimbus
Copy link
Owner

What I fear of, is that, with current library, I had so much weird edge-cases, where dates where formatted in 10 different ways, some even with verbal "friday" wrote in them - and I fear that new exif library would show new, unexpected issues, even tho it promised to be more stable...

I may try out (but don't promise anything) some work in separate branch/beta version, and we will see how well it does...

@tundrablasen
Copy link

Any chance your script gets HEIC and HEVC support for photo and video? Would be really needed for Apple user.

Thanks for your feedback. And thanks for the script

@TheLastGimbus
Copy link
Owner

I will take a look at it when I will have some free time laying around...

@tundrablasen
Copy link

I will take a look at it when I will have some free time laying around...

I think you created here a 💎
The need for your script will explode as closer we getting to June 2021 and google photos kills the storage support. Other cloud providers have more appeal (iCloud photos with more privacy focus) and Microsoft OneDrive (cheaper plans).

therefore I would build the script around these two alternatives. What is need for Apple users to switch to iCloud photos and what is needed for Apple and Android users to switch to onedrive

you already have around 700 stars. This will get huge in the next months

@TheLastGimbus
Copy link
Owner

"a 💎" and "this will get huge in next months" give me back r/wallstreetbets Game Stop vibes again 😆 But thank you for kind words 💖

Altough I personally think that code itself is a big pile of 🍝 💩 and not 💎, at least it works pretty stable and it's ready for another 700 users, and I'm proud of it 👍

If you say that new swarm of user will come here in "June 2021", I may give this bigger priority 💯

@tundrablasen
Copy link

New swarm will definitely come. Many of the non nerds didn’t even Heard- about google change of plans.

So your Script can go 🚀🌓, if you don’t have paper hands

@TheLastGimbus
Copy link
Owner

Damn you were right, it looks like it's getting some more attention nowadays 👀

Kinda shame I didn't do this yet...

@tundrablasen
Copy link

Damn you were right, it looks like it's getting some more attention nowadays 👀

Kinda shame I didn't do this yet...

Yeah that’s what I thought would happen. It’s never too late

@TheLastGimbus
Copy link
Owner

Damn it hit 1K stars 😮 thanks everyone!

I'm writing this to note that I'm not dead and remember about this - tho didn't found it urgent enough 😕

If anyone deperatly needs it (tho I doubt anyone does after half a year of waiting 😆 ) - let me know - otherwise, some features of exif like gps (#5) seem really complicated to migrate to other library 😖

@fishwishes
Copy link

@TheLastGimbus I don't know about desperately, but I would really love this feature. I have a Google Photos library with over a decade of photos that I'm trying to correctly move to a NAS and it seems like your tool is really the closest option for retaining original quality (processing on a Takeout export rather than API sync). But I also have TONS of HEIC/HEVC content from the last several years with new devices, and I have no idea how to account for those...

@Petruchio96
Copy link

Was just about to run this on 8 years of iPhone photos... then i saw this issue not supporting HEIC. I assume that's still the case?

@TheLastGimbus
Copy link
Owner

You should try to run it anyway - it just doesn't support reading/writing their exif values - everything with correct json should work fine 👌

// Actually i may change the name since it looks like it's not supported at all 🤔

@TheLastGimbus TheLastGimbus changed the title HEIC Support HEIC Support for EXIF data Mar 7, 2022
@TheLastGimbus
Copy link
Owner

Hi guys!

After 1 year, it is finally done! Exif from HEIC files are officially supported as a backup from json file not found - as of v3.0.0 🎉

Note that it uses the exif just to set file last modified - it does not corret your exifs if you edited the time in the Photos app 😞

@TheLastGimbus TheLastGimbus unpinned this issue Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants