Support latest version of Chrome!

[jdvegmond]

Expected behaviour

Chimpy should work with the latest version of Chrome. (v74 at moment of writing)

Actual behaviour

Tests are not started, and the following message is shown:
[chimp][helper] setupBrowserAndDDP had error
{ Error: session not created: Chrome version must be between 70 and 73
........

Exact steps to reproduce / repository that demonstrates the problem

Install the latest Chrome version and start a Chimpy test using Chrome.

Version & tools:

Chimpy 0.54.0
Node.js 6.9.4
Windows 10 latest version

[rsshilli]

Ok. I had previously posted a GitHub repo here that you could use in package.json, but I was wrong. The package refused to install correctly out of Github.

So until a new package is posted, to use the latest version of Chrome (v74) you'll have to use my cherry-chimp package:

npm install [email protected] --save-dev

This will likely go away once my changes in #140 are accepted and published.

[jdvegmond]

Thanks, but with help from some colleagues I solved the issue by going into the Chimp folder and updating the chromedriver myself. We found this out because when someone installed Chimpy from scratch they didn't have the problem.

…

On Thu, 16 May 2019 at 21:13, Ryan Shillington ***@***.***> wrote: Ok. I had previously posted a GitHub repo here that you could use in package.json, but I was wrong. Until a new package is posted, to use the latest version of Chrome you'll have to use my cherry-chimp package: npm install ***@***.*** --save-dev This will likely go away once my changes in #140 <#140> are accepted and published. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#138?email_source=notifications&email_token=AHZANLAZRFJFXPVZ5TZLXVDPVWW35A5CNFSM4HIKYXBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVSZGAA#issuecomment-493196032>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHZANLAEBH4B6BET2LMUS3LPVWW35ANCNFSM4HIKYXBA> .

[rsshilli]

When you install Chimpy from scratch, uses the 2.46 driver which is pretty old (it matches Chrome 69). The good/bad thing about 2.46 is that it doesn't tell you that you have the wrong driver. That "feature" wasn't introduced until Chromedriver 70.

FWIW, our docker container refuses to upgrade past Chrome 73 and Chromedriver 74 refuses to work with Chrome 73, so I also created a [email protected] for people who want the proper Chrome 73 drivers.

[hexsprite]

Can chimpy just not install chromedriver and prompt you to install it on the top level if you don't install it? That way we can choose to whatever version we want....

As a workaround, i just rm -fr node_modules/chimpy/node_modules/chromedriver which then picks up the top level version...

[lgandecki]

I'm pretty sure that's what we do in the most recent version (v2.0.0) @hexsprite
#148

is this not working for you properly?

[hexsprite]

@lgandecki unfortunately no... I'm installing using the git+https:// URL. I wonder if that's causing the issue.

Actually re-installing using the NPM installed version seems to work properly... Thanks!