Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized Download Procedure #22

Open
bytebone opened this issue Dec 30, 2021 · 1 comment
Open

Optimized Download Procedure #22

bytebone opened this issue Dec 30, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@bytebone
Copy link

bytebone commented Dec 30, 2021

hey there,
first off - thank you for supplying such a useful app. but i feel like the process could be optimized to take a lot less time.
isnt downloading each svg, then converting them into an html, then into a pdf a very tedious way to do it?
i would think that downloading all the svgs first, then directly putting them into a pdf would be a much more efficient way to handle it.

sadly, im inexperienced with go, so i struggle to do my own tests. but i can say that downloading a single 160 page magazine takes up to 20 minutes, as creating every single pdf page takes about 5 seconds.

let me know what you think of this

@TheAxeDude
Copy link
Owner

This does sound like a greeat idea. I have had issues with page sizing before though, which is why I ended up at the "1 page at a time route". I have recently been experimenting with PagedJS which might be an option worth exploring.

If I ever have free time to play on this, I will let you know!

@TheAxeDude TheAxeDude added the enhancement New feature or request label Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants