You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Addresses Copilot review feedback: .github/workflows/ty.yml sets
`continue-on-error: true` and passes `--exit-zero` ("ty is not yet a
required gate"), so the previous wording implied an enforced gate.
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+2-2Lines changed: 2 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -159,7 +159,7 @@ We want your work to be readable by others; therefore, we encourage you to note
159
159
starting_value =int(input("Please enter a starting value: ").strip())
160
160
```
161
161
162
-
The use of [Python type hints](https://docs.python.org/3/library/typing.html) is encouraged for function parameters and return values. Our automated testing runs [ty](https://docs.astral.sh/ty/) so you may want to run that locally before making your submission.
162
+
The use of [Python type hints](https://docs.python.org/3/library/typing.html) is encouraged for function parameters and return values. Our CI runs [ty](https://docs.astral.sh/ty/)as an informational check that does not block merges yet, so you may want to run it locally before making your submission.
163
163
164
164
```python
165
165
defsum_ab(a: int, b: int) -> int:
@@ -183,7 +183,7 @@ We want your work to be readable by others; therefore, we encourage you to note
183
183
- If you have modified/added documentation work, ensure your language is concise and contains no grammar errors.
184
184
- Do not update the README.md or DIRECTORY.md file which will be periodically autogenerated by our GitHub Actions processes.
185
185
- Add a corresponding explanation to [Algorithms-Explanation](https://github.com/TheAlgorithms/Algorithms-Explanation) (Optional but recommended).
186
-
-All submissions are type-checked with [__ty__](https://docs.astral.sh/ty/) so we encourage you to add [__Python type hints__](https://docs.python.org/3/library/typing.html) where it makes sense to do so.
186
+
-Our CI runs [__ty__](https://docs.astral.sh/ty/) on every pull request as an informational check that does not block merges yet, so we encourage you to add [__Python type hints__](https://docs.python.org/3/library/typing.html) where it makes sense to do so.
187
187
188
188
- Most importantly,
189
189
-__Be consistent in the use of these guidelines when submitting.__
0 commit comments