Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage Issue for HashTable and TimSorter Reducing Overall Code Coverage #465

Open
Kalkwst opened this issue Aug 21, 2024 · 1 comment
Open
Assignees
Labels

Comments

@Kalkwst
Copy link
Contributor

Kalkwst commented Aug 21, 2024

Summary
We’ve encountered a coverage issue related to two classes, HashTable and TimSorter, which is impacting the overall code coverage in our project. Despite the current PR achieving 100% coverage for the changes it introduces, these two classes are not meeting the coverage standards, which is causing a blockage due to Codecov warnings.

To Reproduce

  1. Update your branch with the latest changes from master.
  2. Run Codecov or check the coverage report.
  3. Observe that the overall coverage is lowered due to the indirect changes affecting HashTable and TimSort.

Expected behavior

  • HashTable and TimSort should have adequate unit test coverage.
  • The overall coverage metric should reflect a high coverage rate, ideally not impacted negatively by indirect changes.

Actual behavior

  • HashTable and TimSort are not covered sufficiently.
  • The overall coverage metric is reduced, leading to Codecov warnings and PR blockage.

image

@siriak
Copy link
Member

siriak commented Aug 21, 2024

Thank you for opening the issue, it probably happens because of randomization in tests, so coverage fluctuates a bit. I tried fixing some places where this happened, but never got to all of them. Just to make it clear, you are working on a fix, right? I'll assign you to the issue then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants