Skip to content

Commit d8cba42

Browse files
authored
fix(Badge): fix count slot invalid (#4085)
1 parent b0c2815 commit d8cba42

File tree

4 files changed

+17
-9
lines changed

4 files changed

+17
-9
lines changed

packages/components/avatar/__test__/__snapshots__/index.test.js.snap

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,13 @@ exports[`Avatar & Avatar Groups Avatar Props : style && customStyle 1`] = `
3838
/>
3939
</wx-view>
4040
</wx-view>
41+
<wx-view
42+
ariaHidden="true"
43+
ariaLabel="有0条消息"
44+
class="t-badge--basic t-badge--medium t-badge--circle t-badge--count t-has-count t-class-count"
45+
id="t_badge_0_description"
46+
style=""
47+
/>
4148
</wx-view>
4249
</t-badge>
4350
</wx-view>

packages/components/badge/__test__/index.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ describe('badge', () => {
184184
comp.attach(document.createElement('parent-wrapper'));
185185

186186
const $count = comp.querySelector('.badge >>> .t-badge--basic');
187-
expect($count).toBeUndefined();
187+
expect($count.dom.textContent.trim()).toBe('');
188188

189189
comp.setData({ showZero: true });
190190

packages/components/badge/badge.wxml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
<view
1111
style="{{_._style([style, customStyle])}}"
12-
class="{{_this.getBadgeOuterClass({shape})}} class {{prefix}}-class"
12+
class="{{_this.getBadgeOuterClass({classPrefix, shape})}} class {{prefix}}-class"
1313
aria-labelledby="{{labelID}}"
1414
aria-describedby="{{descriptionID}}"
1515
aria-role="{{ ariaRole || 'option'}}"
@@ -21,14 +21,15 @@
2121
<view
2222
aria-hidden="true"
2323
aria-label="{{ ariaLabel || _.getBadgeAriaLabel({dot, count, maxCount}) }}"
24-
wx:if="{{_this.isShowBadge({dot,count,showZero})}}"
2524
id="{{descriptionID}}"
26-
class="{{_this.getBadgeInnerClass({dot, size, shape, count})}} {{prefix}}-has-count {{prefix}}-class-count"
25+
class="{{_this.getBadgeInnerClass({classPrefix, dot, size, shape, count})}} {{prefix}}-has-count {{prefix}}-class-count"
2726
style="{{_._style([_this.getBadgeStyles({color, offset})])}}"
2827
aria-hidden="true"
2928
aria-label="{{ ariaLabel || _.getBadgeAriaLabel({dot, count, maxCount}) }}"
3029
>
31-
{{ _this.getBadgeValue({dot, count, maxCount}) }}
30+
<block wx:if="{{_this.isShowBadge({dot,count,showZero})}}">
31+
{{ _this.getBadgeValue({dot, count, maxCount}) }}
32+
</block>
33+
<slot else name="count" />
3234
</view>
33-
<slot name="count" />
3435
</view>

packages/components/badge/badge.wxs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,19 +36,19 @@ var getBadgeStyles = function (props) {
3636
};
3737

3838
var getBadgeOuterClass = function (props) {
39-
var baseClass = 't-badge';
39+
var baseClass = props.classPrefix;
4040
var classNames = [baseClass, props.shape === 'ribbon' ? baseClass + '__ribbon-outer' : ''];
4141
return classNames.join(' ');
4242
};
4343

4444
var getBadgeInnerClass = function (props) {
45-
var baseClass = 't-badge';
45+
var baseClass = props.classPrefix;
4646
var classNames = [
4747
baseClass + '--basic',
4848
props.dot ? baseClass + '--dot' : '',
4949
baseClass + '--' + props.size,
5050
baseClass + '--' + props.shape,
51-
!props.dot && props.count ? baseClass + '--count' : '',
51+
!props.dot ? baseClass + '--count' : '',
5252
];
5353
return classNames.join(' ');
5454
};

0 commit comments

Comments
 (0)