Stripping annotations also removes the portable PDB checksum

[rdeago]

Description

Version: 1.1.0

When ExportAnnotations modifies an assembly, the portable PDB checksum disappears. This causes NuGet to reject uploaded symbol package files, as they fail the checksum test due to the fact that there is no checksum to begin with.

This is caused by jbevain/cecil#610 which is also affecting Fody and other projects.

Workarounds proposed so far include embedding debug information in assemblies, and including PDB files in .nupkg packages. None of these applies here, of course, because we cannot make such decisions on the behalf of users.

Configuration

Reproducible by referencing the ReSharper.ExportAnnotations package and setting the StripJetBrainsAnnotations property to true.

Regression?

Not a regression. It's always been this way, but it apparently never affected anyone until I tried to distribute symbol packages for the compiled tasks in Buildvana.Sdk.

Other information

A possible workaround could be: instead of stripping annotations for the assembly, delete it and re-run the Build target without the JETBRAINS_ANNOTATIONS constant. Some quick notes:

• Building twice has an obvious negative impact on performance.
• We should be able to call the Build target again and have MSBuild not skip it just by setting a different set of properties (which we have to do anyway). That's the way multi-targeting works.
• This would also close Stripping annotations also strips the signature away from strong-named assemblies #2 and any other possible problems with assembly modification.

[rdeago]

Fixed by #14. Closing.